dspavlov commented on a change in pull request #89: IGNITE-10454 Create page
with muted tests
URL: https://github.com/apache/ignite-teamcity-bot/pull/89#discussion_r239798051
##########
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/tracked/GetTrackedBranchTestResults.java
##########
@@ -140,4 +145,31 @@ public TestFailuresSummary
getAllTestFailsNoCache(@Nullable @QueryParam("branch"
return tbProc.getTrackedBranchTestFailures(branchOpt, checkAllLogs,
cntLimit, creds);
}
+
+ /**
+ * @param srvId Server id.
+ * @param projectId Project id.
+ * @return Mutes for given server-project pair.
+ */
+ @GET
+ @Path("mutes")
+ public Set<MuteInfo> mutes(
+ @Nullable @QueryParam("serverId") String srvId,
+ @Nullable @QueryParam("projectId") String projectId
+ ) {
+ ICredentialsProv creds = ICredentialsProv.get(req);
+
+ if (F.isEmpty(srvId))
+ srvId = "apache";
Review comment:
Avoid hardcoding. At least use constants - we have method retuning default
server ID.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
