It seems that SharedSecrets is moved to jdk.internal.access package. See PR for OpenJ9 [1].
I believe we should just add export of jdk.internal.access package to our scripts and TC configurations. [1] https://github.com/eclipse/openj9/pull/3824 On Wed, Mar 27, 2019 at 8:33 PM Dmitriy Pavlov <[email protected]> wrote: > > I've played with 2.7.5-RC-1 and Java 12, and unfortunately, Ignite can't > start without changes: > > Exception in thread "main" java.lang.ExceptionInInitializerError > at > org.apache.ignite.internal.util.IgniteUtils.<clinit>(IgniteUtils.java:795) > at org.apache.ignite.internal.IgnitionEx.<clinit>(IgnitionEx.java:209) > at org.apache.ignite.Ignition.start(Ignition.java:348) > at > org.apache.ignite.examples.ExampleNodeStartup.main(ExampleNodeStartup.java:34) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:567) > at com.intellij.rt.execution.application.AppMainV2.main(AppMainV2.java:131) > Caused by: java.lang.RuntimeException: jdk.internal.misc.JavaNioAccess > class is unavailable. > at > org.apache.ignite.internal.util.GridUnsafe.javaNioAccessObject(GridUnsafe.java:1453) > at org.apache.ignite.internal.util.GridUnsafe.<clinit>(GridUnsafe.java:112) > ... 9 more > Caused by: java.lang.ClassNotFoundException: jdk.internal.misc.SharedSecrets > at > java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583) > at > java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) > at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521) > at java.base/java.lang.Class.forName0(Native Method) > at java.base/java.lang.Class.forName(Class.java:332) > at > org.apache.ignite.internal.util.GridUnsafe.javaNioAccessObject(GridUnsafe.java:1446) > ... 10 more > > I'm not sure we can workaround it. So probably fix with JDK.ver>11 is not > correct because for 12 we need some changes. > > > ср, 27 мар. 2019 г. в 17:44, Ilya Kasnacheev <[email protected]>: > > > Hello! > > > > So after rebasing I was actually able to get it to pass: > > > > https://ci.ignite.apache.org/viewLog.html?buildId=3431647&buildTypeId=IgniteTests24Java8_SpiWindows > > - Java 11, passed > > > > https://ci.ignite.apache.org/viewLog.html?buildId=3431619&buildTypeId=IgniteTests24Java8_SpiWindows > > - Java 11 without fix, will fail every time > > > > Regards, > > -- > > Ilya Kasnacheev > > > > > > вт, 26 мар. 2019 г. в 19:41, Ilya Kasnacheev <[email protected]>: > > > > > Hello. > > > > > > Yes, locally this test seems to pass. However, no luck on TC. Maybe my > > > commit is positioned on top of especially unlucky HEAD. > > > > > > Anyway, my point was thatTcpDiscoverySslTrustedUntrustedTest (or any > > other > > > intra-node SSL test) is a sufficient test for IGNITE-11299. > > > > > > It will very reliably hang on Windows/Java 11 without patch and will > > > always pass with my patch (and TLSv1.2). > > > > > > So no additional test is needed - we are testing a known regression here. > > > > > > Regards, > > > -- > > > Ilya Kasnacheev > > > > > > > > > вт, 26 мар. 2019 г. в 13:43, Alexey Goncharuk < > > [email protected] > > > >: > > > > > >> Hello Ilya, > > >> > > >> I do not see any issues with the mentioned test. I see the following > > >> output > > >> in the logs: > > >> > > >> [21:41:44] : [Step 4/5] [2019-03-22 21:41:44,970][INFO ][main][root] >>> > > >> Stopping test: > > >> > > >> > > TcpDiscoveryCoordinatorFailureTest#testCoordinatorFailedNoAddFinishedMessageStartOneNode > > >> in 37768 ms <<< > > >> [21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] >>> > > >> Stopping test class: TcpDiscoveryCoordinatorFailureTest <<< > > >> [21:41:44] : [Step 4/5] [2019-03-22 21:41:44,971][INFO ][main][root] >>> > > >> Starting test class: IgniteClientConnectTest <<< > > >> > > >> The issue with Windows may be long connection timeouts, in this case we > > >> should either split the suite into multiple ones or decrease the SPI > > >> timeouts. > > >> > > >> пн, 25 мар. 2019 г. в 11:24, Ilya Kasnacheev <[email protected] > > >: > > >> > > >> > Hello! > > >> > > > >> > It seems that I can no longer test this case, on account of > > >> > > > >> > > > >> > > TcpDiscoveryCoordinatorFailureTest#testClusterFailedNewCoordinatorInitialized > > >> > hanging every time under Java 11 on Windows. > > >> > > > >> > Alexey, Ivan, can you please take a look? > > >> > > > >> > > > >> > > > >> > > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__ > > >> > > > >> > Regards, > > >> > > > >> > -- > > >> > Ilya Kasnacheev > > >> > > > >> > > > >> > пт, 22 мар. 2019 г. в 16:59, Ilya Kasnacheev < > > [email protected] > > >> >: > > >> > > > >> > > Hello! > > >> > > > > >> > > Basically there is a test that explicitly highlights this problem, > > >> that > > >> > is > > >> > > running SSL tests on Windows + Java 11. They will hang on Master but > > >> pass > > >> > > with this patch. > > >> > > > > >> > > I have started that on TC, results will probably be available later > > >> > today: > > >> > > > > >> > > > > >> > > > >> > > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SpiWindows&tab=buildTypeStatusDiv&branch_IgniteTests24Java8=__all_branches__ > > >> > > (mind the Java version). > > >> > > > > >> > > Regards, > > >> > > -- > > >> > > Ilya Kasnacheev > > >> > > > > >> > > > > >> > > пт, 22 мар. 2019 г. в 14:13, Maxim Muzafarov <[email protected]>: > > >> > > > > >> > >> Dmitry, Ilya, > > >> > >> > > >> > >> Yes, I've looked through those changes [1] as they can affect my > > >> local > > >> > >> PR. Basically, changes look good to me. > > >> > >> > > >> > >> I'm not an expert with CommunicationSpi component, so can miss some > > >> > >> details and I haven't tested these changes under Java 11. One more > > >> > >> thing I'd like to say, I would add additional tests to PR that will > > >> > >> explicitly highlight the problem being solved. > > >> > >> > > >> > >> > > >> > >> [1] https://issues.apache.org/jira/browse/IGNITE-11299 > > >> > >> > > >> > >> On Thu, 21 Mar 2019 at 22:57, Dmitriy Pavlov <[email protected]> > > >> > wrote: > > >> > >> > > > >> > >> > Hi Igniters, > > >> > >> > > > >> > >> > fix https://issues.apache.org/jira/browse/IGNITE-11299 Avoid > > busy > > >> > wait > > >> > >> on > > >> > >> > processWrite during SSL handshake. > > >> > >> > seems to be blocker cause it is related to Java 11 > > >> > >> > > > >> > >> > I see Maxim M left some comments. Ilya K., Maxim M.were these > > >> comments > > >> > >> > addressed? > > >> > >> > > > >> > >> > The ticket is in Patch Available. Reviewer needed. Changes > > located > > >> in > > >> > >> > GridNioServer. > > >> > >> > > > >> > >> > Sincerely, > > >> > >> > Dmitriy Pavlov > > >> > >> > > > >> > >> > P.S. a quite obvious ticket came to sope, as well: > > >> > >> > https://issues.apache.org/jira/browse/IGNITE-11600 > > >> > >> > > > >> > >> > > > >> > >> > чт, 21 мар. 2019 г. в 16:55, Petr Ivanov <[email protected]>: > > >> > >> > > > >> > >> > > Huge +1 > > >> > >> > > > > >> > >> > > Will try to add new JDK in nearest time to our Teamcity. > > >> > >> > > > > >> > >> > > > > >> > >> > > > On 21 Mar 2019, at 16:27, Dmitriy Pavlov <[email protected] > > > > > >> > >> wrote: > > >> > >> > > > > > >> > >> > > > Hi Igniters, > > >> > >> > > > > > >> > >> > > > Meanwhile, Java 12 GA is available. I suggest at least test > > our > > >> > new > > >> > >> tests > > >> > >> > > > scripts with a couple of Java builds. WDYT? > > >> > >> > > > > > >> > >> > > > Sincerely, > > >> > >> > > > Dmitriy Pavlov > > >> > >> > > > > > >> > >> > > > ср, 20 мар. 2019 г. в 19:21, Dmitriy Pavlov < > > >> [email protected]>: > > >> > >> > > > > > >> > >> > > >> Hi Ignite Developers, > > >> > >> > > >> > > >> > >> > > >> In a separate discussion, I've shared a log with all > > commits. > > >> > >> > > >> > > >> > >> > > >> As far as I can see, nobody removed commits from this sheet, > > >> so > > >> > the > > >> > >> > > scope > > >> > >> > > >> of release will be discussed in another way: only explicitly > > >> > >> declared > > >> > >> > > >> commits will be cherry-picked. > > >> > >> > > >> > > >> > >> > > >> Sincerely, > > >> > >> > > >> Dmitriy Pavlov > > >> > >> > > >> > > >> > >> > > > > >> > >> > > > > >> > >> > > >> > > > > >> > > > >> > > > > >
