Hi Denis, Ilya, Thank you so much for sharing feedback. I can understand the difficulties on maintaining different integrations and also upgrading dependencies periodically. I am good with consul integration to be part of separate repository.
I will close the ticket with the info. Regards, Saikat On Tue, Apr 9, 2019 at 11:27 AM Denis Magda <dma...@apache.org> wrote: > I would support this idea of having integrations in separate Github > repositories. Ignite is already overwhelmed with a bunch of integrations > which complicates testing, release procedures, maintenance. Think that we, > as the community, should revisit the current project structure and move > even key integrations like Spark or SpringData to separate repositories. > That's another discussion. > > - > Denis > > > On Tue, Apr 9, 2019 at 2:40 AM Ilya Kasnacheev <ilya.kasnach...@gmail.com> > wrote: > > > Hello! > > > > I'm not sure that we should bundle Consul intergration with Ignite. We > have > > a huge number of integrations and most of those are poorly maintained. I > > think that you should develop it separately, deploy releases to maven > > centra;/ They will be as easily reachable as our own artifacts this way. > > > > Otherwise, the answers is 1) why not, and 2) we're not sure, give it a > try. > > > > Regards, > > -- > > Ilya Kasnacheev > > > > > > вт, 9 апр. 2019 г. в 05:38, Saikat Maitra <saikat.mai...@gmail.com>: > > > > > Hi Ilya, > > > > > > I wanted to raise an PR to include TCPConsulIPFinder as part of Ignite > > > modules and wanted to discuss if consul orbitz client can be used or > > shall > > > we implement it differently. > > > > > > > > > Regards, > > > Saikat > > > > > > On Mon, Apr 8, 2019 at 6:07 AM Ilya Kasnacheev < > > ilya.kasnach...@gmail.com> > > > wrote: > > > > > > > Hello! > > > > > > > > Looks like there's a ready solution for your problem. What do you > have > > > left > > > > unsolved? > > > > > > > > Regards, > > > > -- > > > > Ilya Kasnacheev > > > > > > > > > > > > пн, 8 апр. 2019 г. в 02:42, Saikat Maitra <saikat.mai...@gmail.com>: > > > > > > > > > Hi, > > > > > > > > > > I am looking into this issue > > > > > https://issues.apache.org/jira/browse/IGNITE-1204 and found > > something > > > > > similar ignite consul cluster discovery client here > > > > > > > > > > [https://github.com/andrea-zanetti/ignite-consul] > > > > > > > > > > This library depends on consul orbitz client [ > > > > > https://github.com/rickfast/consul-client] > > > > > > > > > > I wanted to connect to understand if it is something we can use to > > > build > > > > > the consul discovery module? > > > > > > > > > > Regards, > > > > > Saikat > > > > > > > > > > > > > > >
