Thank you so much! пт, 26 июл. 2019 г. в 21:15, Dmitriy Pavlov <dpav...@apache.org>:
> No, you and no one can not be banned because of this :). > > TC is accessible for me, but I'm not too far from its server now. I will > double-check from home later. > > пт, 26 июл. 2019 г. в 18:58, Alexey Zinoviev <zaleslaw....@gmail.com>: > > > Can somebody say me: could I be banned from TC after commit reverting. > > The https://ci.ignite.apache.org/ became inaccessible in a few seconds > > after Dmitry Pavlov reverting my commit. > > > > Maybe it's kind of paranoid mode, but... > > > > > > пт, 26 июл. 2019 г. в 19:16, Alexey Zinoviev <zaleslaw....@gmail.com>: > > > > > Absolutely, at this moment ML visa is not includes the new Checkstyle > > > checker (but it includes licences and javadocs) I support that common > > > things like checkstyle and licences should be separated from local visa > > for > > > different modules and should be run every time > > > > > > Thanks for reverting, Dmitry, I'll create new PR correctly and check it > > > via common approach > > > > > > пт, 26 июл. 2019 г. в 19:11, Dmitriy Pavlov <dpav...@apache.org>: > > > > > >> Hi Maxim, > > >> > > >> It may be reasonable, but probably we should start a separate topic. > > IMO, > > >> some Igniters (sad, but true) may have spam-filter for TC Bot messages > > >> > > >> Sincerely, > > >> Dmitriy Pavlov > > >> > > >> пт, 26 июл. 2019 г. в 17:09, Maxim Muzafarov <maxmu...@gmail.com>: > > >> > > >> > Folks, > > >> > > > >> > I've checked some build associated with PRs related to ML and it > seems > > >> > to me that the Run::ML suite [1] does not include the checkstyle > > >> > suite in its workflow. It's a bit strange for me to add checkstyle, > > >> > licenses headers etc. things to each aggregate suite configuration > > >> > that we want to use. As its related to the code directly the general > > >> > question here is - should we make our build procedure more intuitive > > >> > and turn on checkstyle profile for the Apache Ignite Build suite? > > >> > I think the answer is - yes. > > >> > > > >> > [1] > > >> > > > >> > > > https://ci.ignite.apache.org/viewLog.html?buildId=4381029&buildTypeId=IgniteTests24Java8_RunMl > > >> > > > >> > On Fri, 26 Jul 2019 at 16:54, Alexey Zinoviev < > zaleslaw....@gmail.com > > > > > >> > wrote: > > >> > > > > >> > > Hi, Igniters, many thanks for the update on my PR, I didn't merge > > for > > >> a 3 > > >> > > months and doesn't know that rules were changed > > >> > > Please, revert my commit, I will update my PR according CheckStyle > > job > > >> > > > > >> > > Please, tell me, is CheckStyle bot recommendations and changing of > > PR > > >> > name > > >> > > (with ticket name addition) is enough to finish this issue? > > >> > > > > >> > > Thanks a lot for the clarification > > >> > > > > >> > > пт, 26 июл. 2019 г. в 18:28, Dmitriy Pavlov <dpav...@apache.org>: > > >> > > > > >> > > > +1 to revert. Some day we should learn this process. Maybe this > > day > > >> is > > >> > > > today. > > >> > > > > > >> > > > пт, 26 июл. 2019 г. в 10:00, Nikolay Izhikov < > nizhi...@apache.org > > >: > > >> > > > > > >> > > >> +1 to revert. > > >> > > >> > > >> > > >> В Пт, 26/07/2019 в 09:48 +0300, Павлухин Иван пишет: > > >> > > >> > Alexey, > > >> > > >> > > > >> > > >> > Actually the commit [1] is very suspicious: > > >> > > >> > 1. Commit message "[ML] Hyper-parameter tuning via Genetic > > >> Algorithm > > >> > > >> > (#6713)" does not refer to a ticket. > > >> > > >> > 2. Is there a ticket? Consequently it is not easy to > understand > > >> what > > >> > > >> > was done and check ticket according to regular flow (review, > TC > > >> > run). > > >> > > >> > 3. I skimmed through changes and found several code style > > >> violations > > >> > > >> quite soon. > > >> > > >> > > > >> > > >> > Should we revert the commit [1] and apply the changes > according > > >> to > > >> > our > > >> > > >> > conventions [2]? > > >> > > >> > > > >> > > >> > [1] > > >> > > >> > > >> > > > >> > > > https://github.com/apache/ignite/commit/63fbcbf849640edf140047a5111a58f480c95294 > > >> > > >> > [2] > > >> > > >> > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute > > >> > > >> > > > >> > > >> > чт, 25 июл. 2019 г. в 21:26, <dpavlov.ta...@gmail.com>: > > >> > > >> > > > > >> > > >> > > Hi Igniters, > > >> > > >> > > > > >> > > >> > > I've detected some new issue on TeamCity to be handled. > You > > >> are > > >> > more > > >> > > >> than welcomed to help. > > >> > > >> > > > > >> > > >> > > If your changes can lead to this failure(s): We're > grateful > > >> that > > >> > you > > >> > > >> were a volunteer to make the contribution to this project, but > > >> things > > >> > > >> change and you may no longer be able to finalize your > > contribution. > > >> > > >> > > Could you respond to this email and indicate if you wish > to > > >> > continue > > >> > > >> and fix test failures or step down and some committer may > revert > > >> you > > >> > commit. > > >> > > >> > > > > >> > > >> > > * New Trusted Suite failure in master [Check Code > Style] > > >> > > >> > > >> > > > >> > > > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_CheckCodeStyle&branch=%3Cdefault%3E&tab=buildTypeStatusDiv > > >> > > >> > > Changes may lead to failure were done by > > >> > > >> > > - zaleslaw....@gmail.com > > >> > > >> > https://ci.ignite.apache.org/viewModification.html?modId=888540 > > >> > > >> > > > > >> > > >> > > - Here's a reminder of what contributors were > agreed > > >> to > > >> > do > > >> > > >> > > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute > > >> > > >> > > - Should you have any questions please contact > > >> > > >> dev@ignite.apache.org > > >> > > >> > > > > >> > > >> > > Best Regards, > > >> > > >> > > Apache Ignite TeamCity Bot > > >> > > >> > > https://github.com/apache/ignite-teamcity-bot > > >> > > >> > > Notification generated at 21:26:38 25-07-2019 > > >> > > >> > > > >> > > >> > > > >> > > >> > > > >> > > >> > > >> > > > > > >> > > > >> > > > > > >
