Hi Emmanouil, Agree, let's check that the IP finder functions normally in the cloud environment and the mock tests can be used for regular testing on Team City. That's the way we tested other environment-specific IP finders including the Kubernetes one.
Let us know once the IP finder is tested on AWS and then we can proceed with the review. - Denis On Tue, Jan 14, 2020 at 2:47 AM Emmanouil Gkatziouras <gkatzio...@gmail.com> wrote: > Hi all! > > With regards to the `Node Discovery Using AWS Application ELB` issue [1] > I made this pull request to fix the merge conflicts [2]. > Will also check if the concerns described on the mailing list topic > `Volunteer needed: AWS Elastic Load Balancer IP Finders implemented` are > addressed [3] > Since I did not test it on an AWS infrastructure the next step would be to > spin up some AWS resources and test it. > By doing so it will help me on checking the Amazon S3 Based Discovery issue > [4] . > I will try to make the deployment as infrastructure as code, and see if > this can be of value for the ignite project and testing. > > Kind regards, > Emmanouil > > [1] https://issues.apache.org/jira/browse/IGNITE-8617 > [2] https://github.com/apache/ignite/pull/7247 > [3] > > http://apache-ignite-developers.2346864.n4.nabble.com/Volunteer-needed-AWS-Elastic-Load-Balancer-IP-Finders-implemented-td33847.html#a39793 > [4] https://issues.apache.org/jira/browse/IGNITE-12398 > > > >
