Will fix the compilation shortly, apologies for not checking locally. An additional compilation attempt is a good idea, but: first, I believe, there is still an option to merge a PR directly to apache git, second - when running a check, we need to make sure that master gets fast-forwarded exactly to the revision that was checked (though, it will help to avoid a lot of concurrent merge failures). I have no enough experience with Github, so I am not sure if this is possible.
пн, 20 янв. 2020 г. в 14:40, Anton Vinogradov <a...@apache.org>: > Also, is it possible to perform the same check on the merge attempt? > > Each PR can be merged from GitHub page, can we append check to the "megre > button" flow? > Can we restrict merges bypassing this button? > > On Mon, Jan 20, 2020 at 2:17 PM Anton Vinogradov <a...@apache.org> wrote: > > > Should we perform an additional compilation attempt on pull/xxx/merge at > > each visa request? > > > > On Mon, Jan 20, 2020 at 1:56 PM Pavel Tupitsyn <ptupit...@apache.org> > > wrote: > > > >> > Main question is "how this may happen in case fix got the Visa [2] ?". > >> This can happen because of other changes in master. > >> "Visa" truly works only when master is in the same state during the > merge > >> as it was during TC run. > >> > >> On Mon, Jan 20, 2020 at 1:50 PM Anton Vinogradov <a...@apache.org> wrote: > >> > >> > It seems, this because of IGNITE-12227 fix [1]. > >> > Main question is "how this may happen in case fix got the Visa [2] ?". > >> > > >> > [1] > >> > > >> > > >> > https://ci.ignite.apache.org/viewModification.html?modId=895719&personal=false&buildTypeId=IgniteTests24Java8_BuildApacheIgnite&tab=vcsModificationFiles > >> > [2] > >> > > >> > > >> > https://issues.apache.org/jira/browse/IGNITE-12227?focusedCommentId=17018135&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17018135 > >> > > >> > On Mon, Jan 20, 2020 at 1:43 PM Николай Ижиков <nizhi...@apache.org> > >> > wrote: > >> > > >> > > Hello. Igniters. > >> > > > >> > > Master build fails: > >> > > > >> > > > >> > > > >> > > >> > https://ci.ignite.apache.org/viewLog.html?buildId=4944107&buildTypeId=IgniteTests24Java8_BuildApacheIgnite&tab=buildLog&branch_IgniteTests24Java8=pull%2F7269%2Fhead > >> > > > >> > > [13:37:02][Step 3/4] [ERROR] Failed to execute goal > >> > > org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile > >> > > (default-testCompile) on project ignite-core: Compilation failure: > >> > > Compilation failure: > >> > > [13:37:02][Step 3/4] [ERROR] > >> > > > >> > > >> > /opt/buildagent/work/7bc1c54bc719b67c/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPartitionCounterStateConsistencyVolatileRebalanceTest.java:[25,1] > >> > > cannot find symbol > >> > > [13:37:02][Step 3/4] [ERROR] symbol: static > >> > > IGNITE_BASELINE_AUTO_ADJUST_ENABLED > >> > > [13:37:02][Step 3/4] [ERROR] location: class > >> > > [13:37:02][Step 3/4] [ERROR] > >> > > > >> > > >> > /opt/buildagent/work/7bc1c54bc719b67c/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPartitionCounterStateAbstractTest.java:[162,28] > >> > > cannot find symbol > >> > > [13:37:02][Step 3/4] [ERROR] symbol: variable > >> > > IGNITE_BASELINE_AUTO_ADJUST_ENABLED > >> > > [13:37:02][Step 3/4] [ERROR] location: class > >> > > > >> > > >> > org.apache.ignite.internal.processors.cache.transactions.TxPartitionCounterStateAbstractTest > >> > > [13:37:02][Step 3/4] [ERROR] > >> > > > >> > > >> > /opt/buildagent/work/7bc1c54bc719b67c/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPartitionCounterStateConsistencyVolatileRebalanceTest.java:[40,28] > >> > > cannot find symbol > >> > > [13:37:02][Step 3/4] [ERROR] symbol: variable > >> > > IGNITE_BASELINE_AUTO_ADJUST_ENABLED > >> > > [13:37:02][Step 3/4] [ERROR] location: class > >> > > > >> > > >> > org.apache.ignite.internal.processors.cache.transactions.TxPartitionCounterStateConsistencyVolatileRebalanceTest > >> > > [13:37:02][Step 3/4] [ERROR] > >> > > > >> > > >> > /opt/buildagent/work/7bc1c54bc719b67c/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxPartitionCounterStateConsistencyVolatileRebalanceTest.java:[47,30] > >> > > cannot find symbol > >> > > [13:37:02][Step 3/4] [ERROR] symbol: variable > >> > > IGNITE_BASELINE_AUTO_ADJUST_ENABLED > >> > > [13:37:02][Step 3/4] [ERROR] location: class > >> > > > >> > > >> > org.apache.ignite.internal.processors.cache.transactions.TxPartitionCounterStateConsistencyVolatileRebalanceTest > >> > > > >> > > > >> > > >> > > >
