Artem, I've answered to your question in apache slack. Better to discuss implementation details in ticket comments.
пт, 31 янв. 2020 г. в 21:02, Denis Magda <dma...@apache.org>: > Alex Scherbakof, as the one who created the ticket, could you please help > Artem and share more details? > > - > Denis > > > On Fri, Jan 31, 2020 at 4:54 AM Artem Demchenko <artem4ik2...@gmail.com> > wrote: > >> Hi, everyone! I have a question about the following task: >> https://issues.apache.org/jira/browse/IGNITE-11663. >> >> The description is not quite concrete, so I want to clarify requirements. >> >> Currently, there are >> “internal.processors.cache.persistence.wal.record.RecordTypes.java” class, >> which contains one class field “public static final >> Set<WALRecord.RecordType> DELTA_TYPE_SET = new HashSet<>();” and static >> block to fill set above with particular values. This class has only one >> usage. >> >> My PR https://github.com/apache/ignite/pull/7330 purpose to move all >> logic >> from “internal.processors.cache.persistence.wal.record.RecordTypes.java” to >> the only place where it used >> “internal.processors.cache.persistence.wal.SingleSegmentLogicalRecordsIterator.java”. >> >> Am I doing everything right or not? If not, what has to be done? >> >> >> -- >> Demchenko Artem. >> > -- Best regards, Alexei Scherbakov
