Fixed your comments! Stepan, please rebuild the release and test! чт, 13 февр. 2020 г. в 17:22, Alexey Zinoviev <zaleslaw....@gmail.com>:
> Should I wait any ML-related issues in examples? > I could wait a day or two if you are going to continue your testing deals > with ML and examples to push changes together. > > Are you running your examples on the release staging as a ignite > dependency, isn't it? > > > чт, 13 февр. 2020 г. в 14:37, Stepan Pilschikov <pilshchikov....@gmail.com > >: > >> filled ticket - https://issues.apache.org/jira/browse/IGNITE-12673 >> >> чт, 13 февр. 2020 г. в 13:46, Alexey Zinoviev <zaleslaw....@gmail.com>: >> >>> I suppose one ticket is enough, collect where all your nites and thoughts >>> >>> чт, 13 февр. 2020 г., 12:12 Stepan Pilschikov <pilshchikov....@gmail.com >>> >: >>> >>>> And one (three) more thing >>>> >>>> In TutorialStepByStepExample we running 17 examples >>>> First 12 logging is pretty good and looks like "Tutorial step N: name" >>>> -> model -> accuracy -> "Tutorial step N: completed" >>>> But then starting with 13 this pattern is kind of broke, step start and >>>> step completion is missing >>>> >>>> Also want to admin that >>>> Step_8_CV_with_Param_Grid_and_metrics_and_pipeline is haven't step >>>> completion log >>>> And complete log for Step_9_Scaling_With_Stacking looks like 'Tutorial >>>> step 5 (scaling) example completed' >>>> >>>> i don't know, should i made some ticket? One ticket for each problem or >>>> one for all or you can fix it in one commit? because fixes quite small >>>> >>>> ср, 12 февр. 2020 г. в 16:31, Alexey Zinoviev <zaleslaw....@gmail.com>: >>>> >>>>> Yes, you are right. Missed resources, I'll remove them tomorrow >>>>> >>>>> ср, 12 февр. 2020 г. в 16:23, Stepan Pilschikov < >>>>> pilshchikov....@gmail.com>: >>>>> >>>>>> With mnist_tf_model in same directory >>>>>> All others looks right >>>>>> >>>>>> ср, 12 февр. 2020 г. в 16:21, Stepan Pilschikov < >>>>>> pilshchikov....@gmail.com>: >>>>>> >>>>>>> Hmm, interesting, got it >>>>>>> Also found >>>>>>> apache-ignite-2.8.0-bin/examples/src/main/resources/models/mleap >>>>>>> I think its also should be removed then >>>>>>> >>>>>>> ср, 12 февр. 2020 г. в 16:11, Alexey Zinoviev < >>>>>>> zaleslaw....@gmail.com>: >>>>>>> >>>>>>>> Please, have a look to the next ticket >>>>>>>> https://issues.apache.org/jira/browse/IGNITE-12659 >>>>>>>> Also tensorflow packages are blockers for IGFS deprecation and >>>>>>>> removal. >>>>>>>> >>>>>>>> ср, 12 февр. 2020 г. в 15:58, Alexey Zinoviev < >>>>>>>> zaleslaw....@gmail.com>: >>>>>>>> >>>>>>>>> They are not lost, they are removed from release branch due to a >>>>>>>>> lot of bugs, cves and so on, don't worry about that. >>>>>>>>> >>>>>>>>> ср, 12 февр. 2020 г., 14:31 Stepan Pilschikov < >>>>>>>>> pilshchikov....@gmail.com>: >>>>>>>>> >>>>>>>>>> Also lost ignite-ml-tensorflow-model-parser and ignite-tensorflow >>>>>>>>>> in libs/optional >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> ср, 12 февр. 2020 г. в 14:25, Stepan Pilschikov < >>>>>>>>>> pilshchikov....@gmail.com>: >>>>>>>>>> >>>>>>>>>>> But now have new problems >>>>>>>>>>> I build ignite-2.8 build on TC >>>>>>>>>>> https://ci.ignite.apache.org/buildConfiguration/Releases_ApacheIgniteMain_ReleaseBuild/5043672 >>>>>>>>>>> Previous >>>>>>>>>>> https://ci.ignite.apache.org/buildConfiguration/Releases_ApacheIgniteMain_ReleaseBuild/4988324 >>>>>>>>>>> >>>>>>>>>>> New build much lighter >>>>>>>>>>> Previous: 5.7 Gb >>>>>>>>>>> Current: 4.3 Gb >>>>>>>>>>> And its looks like something missing, on a first look i notice >>>>>>>>>>> that /libs/optional/ignite-ml-mleap-model-parser lost completely >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> ср, 12 февр. 2020 г. в 14:18, Stepan Pilschikov < >>>>>>>>>>> pilshchikov....@gmail.com>: >>>>>>>>>>> >>>>>>>>>>>> Thanks for fix >>>>>>>>>>>> Duplicated examples deleted and tutorial works on real (1+ >>>>>>>>>>>> node) cluster now >>>>>>>>>>>> I think ticket can be closed, have no power here >>>>>>>>>>>> >>>>>>>>>>>> вт, 11 февр. 2020 г. в 20:44, Alexey Zinoviev < >>>>>>>>>>>> zaleslaw....@gmail.com>: >>>>>>>>>>>> >>>>>>>>>>>>> Sorry, for that, but I it touches ML-related stuff only and >>>>>>>>>>>>> doesn't influence on any another module. >>>>>>>>>>>>> I merged them to master later (currently, I have a 4 tickets >>>>>>>>>>>>> in a queue). >>>>>>>>>>>>> >>>>>>>>>>>>> Will keep in mind for the next fixes >>>>>>>>>>>>> >>>>>>>>>>>>> вт, 11 февр. 2020 г. в 18:58, Maxim Muzafarov < >>>>>>>>>>>>> mmu...@apache.org>: >>>>>>>>>>>>> >>>>>>>>>>>>>> Alexey, >>>>>>>>>>>>>> >>>>>>>>>>>>>> Is the approach when we cherry-pick fixes to the 2.8 only >>>>>>>>>>>>>> after all >>>>>>>>>>>>>> fixes have verified in the master branch better? I just want >>>>>>>>>>>>>> to be >>>>>>>>>>>>>> sure the release branch to be stable enough. >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Tue, 11 Feb 2020 at 18:36, Alexey Zinoviev < >>>>>>>>>>>>>> zaleslaw....@gmail.com> wrote: >>>>>>>>>>>>>> > >>>>>>>>>>>>>> > Fixed both in release branch 2.8. Please verify and let me >>>>>>>>>>>>>> know >>>>>>>>>>>>>> > >>>>>>>>>>>>>> > вт, 11 февр. 2020 г. в 14:58, Stepan Pilschikov < >>>>>>>>>>>>>> pilshchikov....@gmail.com>: >>>>>>>>>>>>>> > >>>>>>>>>>>>>> > > And one more >>>>>>>>>>>>>> > > https://issues.apache.org/jira/browse/IGNITE-12658 - >>>>>>>>>>>>>> > > TutorialStepByStepExample example failed if cluster with >>>>>>>>>>>>>> more then 1 node >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > > вт, 11 февр. 2020 г. в 11:52, Alexey Zinoviev < >>>>>>>>>>>>>> zaleslaw....@gmail.com>: >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > >> Great, thank you so much, will fix next week >>>>>>>>>>>>>> > >> >>>>>>>>>>>>>> > >> вт, 11 февр. 2020 г., 11:39 Stepan Pilschikov < >>>>>>>>>>>>>> pilshchikov....@gmail.com >>>>>>>>>>>>>> > >> >: >>>>>>>>>>>>>> > >> >>>>>>>>>>>>>> > >>> Hi, Alexey, could you please looking on one small >>>>>>>>>>>>>> accident happen in ML >>>>>>>>>>>>>> > >>> examples: >>>>>>>>>>>>>> > >>> https://issues.apache.org/jira/browse/IGNITE-12657 - 2 >>>>>>>>>>>>>> examples exactly >>>>>>>>>>>>>> > >>> the same. >>>>>>>>>>>>>> > >>> >>>>>>>>>>>>>> > >>> Also want to say that all previous examples have one >>>>>>>>>>>>>> common approach for >>>>>>>>>>>>>> > >>> meaningful output, like ">>> Something important". In >>>>>>>>>>>>>> this two i seeing >>>>>>>>>>>>>> > >>> different one, could you please also pay attention to >>>>>>>>>>>>>> it. >>>>>>>>>>>>>> > >>> >>>>>>>>>>>>>> > >>> Best regards, >>>>>>>>>>>>>> > >>> Stepan >>>>>>>>>>>>>> > >>> >>>>>>>>>>>>>> > >> >>>>>>>>>>>>>> >>>>>>>>>>>>>
