Maxim, Fixes are in ignite-2.8 now, and builds have passed [1]. I think we can proceed.
Thank you and sorry for the broken build. [1] https://ci.ignite.apache.org/buildConfiguration/ApacheIgniteReleaseJava8_PrepareVote3BuildNuGetPackages/5083539?buildTab=overview On Wed, Feb 26, 2020 at 8:46 PM Pavel Tupitsyn <ptupit...@apache.org> wrote: > I'm running a final check in branch ignite-2.8-dotnet-build-fix, should be > done soon. > After that I'll merge the changes into ignite-2.8 (and backport to > master), and we can proceed. > > I had to fix both TC project and the build script. > There were a few regressions introduced by various recent changes. > > > Can you also provide some details - which exactly artefacts should I > check on staging resource after the [1] suite execution? > We are supposed to verify that NuGet packages are valid by installing them > and starting Ignite. > However, we added an automatic check recently: `Run NuGet verification > script` build step. > So the only thing to check is that new package appears on MyGet [1] > (scroll down to see versions and dates) > > [1] > https://www.myget.org/feed/apache-ignite-staging/package/nuget/Apache.Ignite > > > On Wed, Feb 26, 2020 at 7:42 PM Maxim Muzafarov <mmu...@apache.org> wrote: > >> Pavel, >> >> >> Thank you for your help. >> Please, let me know when I can proceed with a vote preparation. >> >> >> Can you also provide some details - which exactly artefacts should I >> check on staging resource after the [1] suite execution? >> >> [1] >> https://ci.ignite.apache.org/viewType.html?buildTypeId=ApacheIgniteReleaseJava8_PrepareVote3BuildNuGetPackages >> >> On Wed, 26 Feb 2020 at 10:46, Pavel Tupitsyn <ptupit...@apache.org> >> wrote: >> > >> > Maxim, I did a quick fix for the script, but it did not work. >> > Investigating further, will get back to you later today. >> > >> > On Tue, Feb 25, 2020 at 10:10 PM Maxim Muzafarov <mmu...@apache.org> >> wrote: >> >> >> >> Pavel, >> >> >> >> >> >> Can you assist me with preparing NuGet staging according to the >> >> release steps [1]? I've double-checked everything related to the build >> >> but suite [2] for preparing nuget package still fails (sorry for >> >> running it multiple times). >> >> >> >> I see some issues in the log which may be related to the file copy in >> >> the build script which recently changed [4]. >> >> I'm still digging in, but anyway can you take a look and help? >> >> >> >> >> >> Step 2: >> >> Copy-Item : Cannot find path >> >> >> 'C:\BuildAgent\work\3722fcb3466a49e6\src\modules\platforms\dotnet\Apache.Ignite.Core.dll'because >> >> it does not exist. >> >> >> >> Step 3: >> >> Cannot find path >> >> >> 'C:\BuildAgent\work\3722fcb3466a49e6\src\modules\platforms\dotnet\Apache.Ignite.Core\bin\Release\Apache.Ignite.Core.dll' >> >> because it does not exist. >> >> At >> C:\BuildAgent\work\3722fcb3466a49e6\src\modules\platforms\dotnet\build.ps1:283 >> >> char:47 >> >> >> >> pack: invalid arguments. >> >> >> >> >> >> [1] >> https://cwiki.apache.org/confluence/display/IGNITE/Release+Process#ReleaseProcess-4.4.2.PrepareNuGetstaging >> >> [2] >> https://ci.ignite.apache.org/viewType.html?buildTypeId=ApacheIgniteReleaseJava8_PrepareVote3BuildNuGetPackages >> >> [3] >> https://ci.ignite.apache.org/viewLog.html?buildId=5080553&buildTypeId=ApacheIgniteReleaseJava8_PrepareVote3BuildNuGetPackages&tab=buildLog >> >> [4] https://issues.apache.org/jira/browse/IGNITE-12604 >> >> >> >> On Fri, 21 Feb 2020 at 10:36, Maxim Muzafarov <mmu...@apache.org> >> wrote: >> >> > >> >> > Denis, >> >> > >> >> > >> >> > Currently, we have no blockers. I'm preparing the build. >> >> > >> >> > On Thu, 20 Feb 2020 at 21:10, Denis Magda <dma...@apache.org> wrote: >> >> > > >> >> > > Folks, >> >> > > >> >> > > Is there anything else apart from the open documentation tickets >> that >> >> > > prevent us from starting the release vote? I think that it should >> take >> >> > > around two weeks to run the release through the vote and announce >> it. The >> >> > > top doc changes should be finished throughout that time already. >> >> > > >> >> > > - >> >> > > Denis >> >> > > >> >> > > >> >> > > On Wed, Feb 19, 2020 at 9:55 AM Maxim Muzafarov <mmu...@apache.org> >> wrote: >> >> > > >> >> > > > Ilya, >> >> > > > >> >> > > > >> >> > > > I think we must accept only blocker issues to the release branch. >> >> > > > >> >> > > > My previous experience tells me that even a small change which >> seems >> >> > > > absolutely easy and clear can break everything. So, let's move >> this >> >> > > > issue [1] to the next release. Currently, it doesn't look like a >> >> > > > blocker. >> >> > > > >> >> > > > [1] https://issues.apache.org/jira/browse/IGNITE-12672 >> >> > > > >> >> > > > On Tue, 18 Feb 2020 at 13:51, Maxim Muzafarov <mmu...@apache.org> >> wrote: >> >> > > > > >> >> > > > > Igniters, >> >> > > > > >> >> > > > > >> >> > > > > I've prepared the issue [1] and PR [2] with removing @deprecate >> >> > > > > annotation on DataRegionMetrics and adding @IgniteExperimental >> to the >> >> > > > > new metrics API. >> >> > > > > Can anyone review my changes? >> >> > > > > >> >> > > > > >> >> > > > > [1] https://issues.apache.org/jira/browse/IGNITE-12690 >> >> > > > > [2] https://github.com/apache/ignite/pull/7440 >> >> > > > > >> >> > > > > On Tue, 18 Feb 2020 at 13:42, Ilya Kasnacheev < >> ilya.kasnach...@gmail.com> >> >> > > > wrote: >> >> > > > > > >> >> > > > > > Hello! >> >> > > > > > >> >> > > > > > I have just merged a fix for embarrassing issue where you >> could UPDATE >> >> > > > > > entries with Spring Data, but not "Update" or "update" them. >> >> > > > > > >> >> > > > > > I suggest adding this fix to the scope of 2.8, since Spring >> Data is >> >> > > > popular >> >> > > > > > and it does not in any way affect code outside of its >> modules. >> >> > > > > > >> >> > > > > > https://issues.apache.org/jira/browse/IGNITE-12672 >> >> > > > > > >> >> > > > > > WDYT? >> >> > > > > > >> >> > > > > > Regards, >> >> > > > > > -- >> >> > > > > > Ilya Kasnacheev >> >> > > > > > >> >> > > > > > >> >> > > > > > пн, 17 февр. 2020 г. в 12:44, Maxim Muzafarov < >> mmu...@apache.org>: >> >> > > > > > >> >> > > > > > > Alexey, >> >> > > > > > > >> >> > > > > > > >> >> > > > > > > Yes. I will remove @deprecation according to the vote >> results and >> >> > > > will >> >> > > > > > > go further with the release steps [1] since there no >> blockers left. >> >> > > > > > > >> >> > > > > > > >> >> > > > > > > [1] >> >> > > > >> https://cwiki.apache.org/confluence/display/IGNITE/Release+Process >> >> > > > > > > >> >> > > > > > > On Mon, 17 Feb 2020 at 11:48, Alexey Goncharuk >> >> > > > > > > <alexey.goncha...@gmail.com> wrote: >> >> > > > > > > > >> >> > > > > > > > Folks, >> >> > > > > > > > >> >> > > > > > > > I have merged IGNITE-12650 (mark MVCC as experimental) >> to master >> >> > > > and >> >> > > > > > > > ignite-2.8. What's left? Should we remove deprecation >> from the old >> >> > > > > > > metrics >> >> > > > > > > > and start the vote? >> >> > > > > > > >> >> > > > >> >
