Hi Ilya, Mikhail I have updated the PR as per review comments.
Please take a look and share your feedback. PR https://github.com/apache/ignite-extensions/pull/5 https://github.com/apache/ignite/pull/7240 Regards, Saikat On Tue, Feb 11, 2020 at 7:17 PM Saikat Maitra <saikat.mai...@gmail.com> wrote: > Hello, > > Can someone please help in review for these following PRs. I have > received approval for release process from Alexey and would need a code > review approval for following PR. > > Jira https://issues.apache.org/jira/browse/IGNITE-12358 > > PR https://github.com/apache/ignite-extensions/pull/5 > https://github.com/apache/ignite/pull/7240 > > > Regards, > Saikat > > On Fri, Jan 17, 2020 at 8:38 PM Saikat Maitra <saikat.mai...@gmail.com> > wrote: > >> Yes sure, thank you Denis >> >> Regards, >> Saikat >> >> On Thu, Jan 16, 2020 at 3:53 PM Denis Magda <dma...@apache.org> wrote: >> >>> Hi Saikat, >>> >>> Let's wait while Alex Goncharuk checks a similar PR here: >>> >>> http://apache-ignite-developers.2346864.n4.nabble.com/IGNITE-12361-Migrate-Flume-module-to-ignite-extensions-td45010.html >>> >>> After that, we can return to this pending pull request. >>> >>> - >>> Denis >>> >>> >>> On Sun, Jan 12, 2020 at 12:59 PM Saikat Maitra <saikat.mai...@gmail.com> >>> wrote: >>> >>> > Hi, >>> > >>> > I have raised PR for Ignite zeromq migration to Ignite Extensions repo. >>> > >>> > Jira https://issues.apache.org/jira/browse/IGNITE-12358 >>> > >>> > PR https://github.com/apache/ignite-extensions/pull/5 >>> > https://github.com/apache/ignite/pull/7240 >>> > >>> > Please review and share feedback. >>> > >>> > This is part of our Modularization effort for Streamer modules >>> > >>> > https://issues.apache.org/jira/browse/IGNITE-12355 >>> > >>> > Regards, >>> > Saikat >>> > >>> >>
