Folks,
I've merged the changes. Thanks everyone for the help. Here are a few tasks that I'm going to complete too. https://issues.apache.org/jira/browse/IGNITE-12968 https://issues.apache.org/jira/browse/IGNITE-12967 https://issues.apache.org/jira/browse/IGNITE-12961 On Wed, 29 Apr 2020 at 21:21, Denis Magda <dma...@apache.org> wrote: > > Maxim, > > Ok, let's follow your plan. Ping me once the docs are ready. It's > definitely not a blocker for merging the feature into the master. We can > always adjust the implementation in the master before a public release. > > Btw, could you please fill in the "readiness estimated data" column in the > roadmap draft? I've added this snapshots to the table earlier: > https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Roadmap > > - > Denis > > > On Wed, Apr 29, 2020 at 9:17 AM Maxim Muzafarov <mmu...@apache.org> wrote: > > > Denis, > > > > No, I don't. I'm planning to work on documentation pages right after > > we'll finish with the source code changes. I will be very grateful if > > you will help with the review of the documentation. > > > > Currently, the approach is very straightforward and simple and I doubt > > we can change anything from the user's standpoint: > > 1. The single method for creating snapshots of the whole persisted > > cluster caches - createSnapshot(name); > > 2. Users can change the location of the base snapshot directory to any > > he likes (absolute path or relative path can be used, available from > > IgniteConfiguration); > > 3. The created snapshot will have the same directory structure as the > > Ignite instances have; > > 4. Users will be able to start Ignite instances right from snapshot > > directory and all will work fine for them (with respect to consistent > > nodeId). > > > > On Wed, 29 Apr 2020 at 19:06, Denis Magda <dma...@apache.org> wrote: > > > > > > Hi Maxim, > > > > > > Do you have a draft of docs in any form explaining how the feature is > > > supposed to be used (snapshots creation, restore procedure, > > > setting/changing snapshots location, etc. - essential operations for such > > > capabilities)? I can help with the review from the user standpoint and > > > might advise usability improvements. > > > > > > - > > > Denis > > > > > > > > > On Wed, Apr 29, 2020 at 8:57 AM Maxim Muzafarov <mmu...@apache.org> > > wrote: > > > > > > > Folks, > > > > > > > > > > > > I'm going to merge this issue [1] on the 1-st day of May. > > > > If you still have any questions or PR improvement suggestions, please > > > > let me know. > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-11073 > > > > > > > > On Mon, 27 Apr 2020 at 18:27, Maxim Muzafarov <mmu...@apache.org> > > wrote: > > > > > > > > > > Alexey, > > > > > > > > > > > > > > > From my point of view, the feature is fully self-sufficient and ready > > > > > for a release (with a small caveat): > > > > > - administrators will be able to create snapshots without writing > > > > java-code; > > > > > - developers will be able to create snapshots through java API; > > > > > > > > > > The documentation pages for creating and restoring procedures with > > > > > examples will be completed by me prior to release this feature for > > our > > > > > end-users. > > > > > > > > > > All other features mentioned in this list [1] adds convenience for > > > > > users but not mandatory. I'll try to finish these tasks from the list > > > > > [1] prior to release: > > > > > - support snapshot creation from a client node > > > > > - add starting snapshot via control.sh > > > > > > > > > > Are there any details I've missed? > > > > > > > > > > > > > > > [1] > > https://github.com/apache/ignite/pull/7607#issuecomment-618964647 > > > > > > > > > > On Mon, 27 Apr 2020 at 18:12, Alexey Goncharuk > > > > > <alexey.goncha...@gmail.com> wrote: > > > > > > > > > > > > Maxim, > > > > > > > > > > > > I saw the list of the tickets you want to work on in the PR, it > > looks > > > > nice. > > > > > > I was wondering, what part of that list are you planning to > > implement > > > > > > before the feature is released to end users? For example, I agree > > with > > > > > > Slava that we should implement a command-line utility part for > > > > snapshots > > > > > > before the release, however I think it's better to do it in a > > separate > > > > > > ticket. > > > > > > > > > > > > I know we do not have a strict policy regarding big features > > > > development in > > > > > > the community, so perhaps it's a good time to discuss this? If we > > are > > > > ok > > > > > > with merging separate tickets to master, how we ensure a complete > > > > feature > > > > > > is released to public? If not, should we create a feature branch > > and > > > > wait > > > > > > for all related tickets to be merged there? Will be glad to discuss > > > > this in > > > > > > a separate thread if needed. > > > > > > > > > > > > пн, 27 апр. 2020 г. в 14:38, Maxim Muzafarov <mmu...@apache.org>: > > > > > > > > > > > > > Folks, > > > > > > > > > > > > > > > > > > > > > Are there any cases left which we need to discuss? > > > > > > > > > > > > > > Do you have any questions? > > > > > > > I'm ready to provide all the details you need for the review. > > > > > > > > > > > > > > Who else what to take a look at my changes [1] [2]? > > > > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-11073 > > > > > > > [2] https://github.com/apache/ignite/pull/7607 > > > > > > > > > > > > > > On Fri, 24 Apr 2020 at 15:01, Maxim Muzafarov <mmu...@apache.org > > > > > > > wrote: > > > > > > > > > > > > > > > > Alexey, > > > > > > > > > > > > > > > > > > > > > > > > I've addressed all your comments, please, take a look at the PR > > > > [1]. > > > > > > > > Additional tests were added. > > > > > > > > Additional comments with further steps were added. > > > > > > > > > > > > > > > > > > > > > > > > [1] https://github.com/apache/ignite/pull/7607 > > > > > > > > [2] https://issues.apache.org/jira/browse/IGNITE-11073 > > > > > > > > > > > > > > > > On Tue, 21 Apr 2020 at 09:53, Alexey Goncharuk > > > > > > > > <alexey.goncha...@gmail.com> wrote: > > > > > > > > > > > > > > > > > > Maxim, > > > > > > > > > > > > > > > > > > I've left my comments in the PR. > > > > > > > > > > > > > > > > > > пн, 20 апр. 2020 г. в 12:52, Maxim Muzafarov < > > mmu...@apache.org > > > > >: > > > > > > > > > > > > > > > > > > > Alex P, > > > > > > > > > > Thank you for the great sophisticated review. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Alexey G, > > > > > > > > > > Will you take a look at my changes[1]? > > > > > > > > > > The fresh TC.Bot visa attached. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-11073 > > > > > > > > > > > > > > > > > > > > On Mon, 20 Apr 2020 at 11:54, Alex Plehanov < > > > > plehanov.a...@gmail.com > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > Maxim, I've reviewed your PR and it looks good to me. > > Good > > > > job! > > > > > > > > > > > > > > > > > > > > > > пт, 10 апр. 2020 г. в 19:43, Alexey Goncharuk < > > > > > > > > > > alexey.goncha...@gmail.com>: > > > > > > > > > > > > > > > > > > > > > > > Maxim, > > > > > > > > > > > > > > > > > > > > > > > > Thanks for raising this PR. I will do a review during > > next > > > > week. > > > > > > > > > > > > > > > > > > > > > > > > --AG > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
