Hi Mikhail, Since spring-data-commons is common module and used internally we should be ok to not rename it to spring-data-commons-ext.
Thank you for clarifying. Regards, Saikat On Thu, Nov 19, 2020 at 5:02 AM Mikhail Petrov <pmgheap....@gmail.com> wrote: > Petr, > > The purpose of the spring-data-commons modules is to store the general > classes needed by spring-data extensions to avoid redundant code > duplication between different version of Spring Data integration. I > don't think it can be reused outside the "extensions" scope. Why can't > it be placed in the ignite-extensions repository? > > Alexey, > > I don't mind if all extensions are released. I proposed to release > spring-data modules in the first place because Spring Data thin client > support is not included in any Ignite release and is crucial for some > users. > > Regards, > Mikhail > > On 19.11.2020 12:31, Petr Ivanov wrote: > > If it is not an extensions, so why do we put it to ignite-extensions > repository? > > > > Do we need additional separate ignite-utilities repository for modules > like spring-data-commons? > > > > > > > >> On 19 Nov 2020, at 12:08, Mikhail Petrov <pmgheap....@gmail.com> wrote: > >> > >> Saikat, > >> > >> spring-data-commons is a utility Ignite module that does not provide > integration with anything and is only needed to store Spring Data > version-independent classes for "spring-data" modules. > >> So, spring-data-commons is not an "extension". > >> > >> Should we rename it in this case? > >> > >> Regards, > >> Mikhail > >> > >> > >> On 19.11.2020 10:55, Petr Ivanov wrote: > >>> No 11 separate votes, but 11 separate tags is all I am proposing :) > >>> > >>> > >>>> On 19 Nov 2020, at 10:33, Denis Magda <dma...@apache.org> wrote: > >>>> > >>>> 11+ separate votes is an overkill. We certainly want, and agreed, to > be > >>>> able to release each extension separately. But I see nothing wrong if > >>>> releases of N extensions are passed through a single vote. > >>>> > >>>> On Wednesday, November 18, 2020, Petr Ivanov <mr.wei...@gmail.com> > wrote: > >>>> > >>>>> I would object against all together release of these modules if this > >>>>> process will be done in single release branch / tag. > >>>>> Despite of the fact that all these extensions are in single > repository, we > >>>>> have to treat them as separate projects with separate release cycle > and > >>>>> release each one of them in their own tag with correct naming we were > >>>>> discussing previously. > >>>>> > >>>>> > >>>>>> On 19 Nov 2020, at 04:26, Saikat Maitra <saikat.mai...@gmail.com> > wrote: > >>>>>> > >>>>>> Hi, > >>>>>> > >>>>>> Mikhail, Can we please rename ignite-spring-data-commons to > >>>>>> ignite-spring-data-commons-ext? > >>>>>> > >>>>>> Denis, > >>>>>> > >>>>>> We are good to release the following migrated modules as well... > >>>>>> > >>>>>> ignite-flink-ext > >>>>>> ignite-flume-ext > >>>>>> ignite-pub-sub-ext > >>>>>> ignite-zeromq-ext > >>>>>> ignite-twitter-ext > >>>>>> ignite-rocketmq-ext > >>>>>> ignite-mqtt-ext > >>>>>> ignite-storm-ext > >>>>>> ignite-camel-ext > >>>>>> ignite-jms11-ext > >>>>>> ignite-kafka-ext > >>>>>> > >>>>>> It will be great if we can release all these modules also together. > >>>>>> > >>>>>> Regards, > >>>>>> Saikat > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> On Wed, Nov 18, 2020 at 8:00 AM Mikhail Petrov < > pmgheap....@gmail.com> > >>>>>> wrote: > >>>>>> > >>>>>>> Denis, > >>>>>>> > >>>>>>> I omitted "-ext" for simplicity. Currently, this suffix is present > in > >>>>>>> the name of all Spring Data integration modules [1], [2], [3]. > >>>>>>> > >>>>>>> [1] - > >>>>>>> > >>>>>>> https://github.com/apache/ignite-extensions/tree/master/ > >>>>> modules/spring-data-2.2-ext > >>>>>>> [2] - > >>>>>>> > >>>>>>> https://github.com/apache/ignite-extensions/tree/master/ > >>>>> modules/spring-data-2.0-ext > >>>>>>> [3] - > >>>>>>> > >>>>>>> https://github.com/apache/ignite-extensions/tree/master/ > >>>>> modules/spring-data-ext > >>>>>>> Regards, > >>>>>>> Mikhail > >>>>>>> > >>>>>>> On 18.11.2020 16:26, Denis Magda wrote: > >>>>>>>> Are we keeping the original names of theses Spring modules? In > separate > >>>>>>>> threads I saw that the names of other extensions end with “ext”. > >>>>>>>> > >>>>>>>> Also, how about making a single release of all the extensions > that were > >>>>>>>> migrated from the main Ignite repo. There are many of them > waiting for > >>>>>>> this > >>>>>>>> to happen. Saikat, Alex Goncharuk what do you think? > >>>>>>>> > >>>>>>>> Denis > >>>>>>>> > >>>>>>>> On Wednesday, November 18, 2020, Mikhail Petrov < > pmgheap....@gmail.com > >>>>>>>> wrote: > >>>>>>>> > >>>>>>>>> Hello, Igniters. > >>>>>>>>> > >>>>>>>>> Since the migration of Ignite Spring Data modules to extensions, > thin > >>>>>>>>> client support for Spring Data integration was implemented. - > [1]. > >>>>>>>>> > >>>>>>>>> To make this feature available for users, I propose to start the > >>>>> release > >>>>>>>>> process of the following modules: > >>>>>>>>> > >>>>>>>>> * ignite-spring-data > >>>>>>>>> * ignite-spring-data_2.0 > >>>>>>>>> * ignite-spring-data_2.2 > >>>>>>>>> * ignite-spring-data-commons > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> Any objections to it? > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> [1] - https://issues.apache.org/jira/browse/IGNITE-13519 > >>>>>>>>> > >>>>>>>>> Regards, > >>>>>>>>> Mikhail > >>>>>>>>> > >>>>>>>>> > >>>> -- > >>>> - > >>>> Denis >
