We can run dependency:tree command and search for guava in transitive 
dependencies.
Can you describe how it should be and where should this explicit dependency 
reside?

> On 13 Sep 2021, at 17:15, Alexander Polovtcev <alexpolovt...@gmail.com> wrote:
> 
> Petr,
> In the original thread we decided to add Guava as an explicit dependency in
> order to avoid dependency conflicts and to possibly shade it later. If
> there exists a check that will scan for Guava imports in Ignite code, that
> would probably be nice to have.
> 
> On Mon, Sep 13, 2021 at 12:54 PM Petr Ivanov <mr.wei...@gmail.com> wrote:
> 
>> Should we somehow restrict using this dependency in the project with Maven
>> (or any other tools)?
>> 
>>> On 13 Sep 2021, at 12:47, Alexander Polovtcev <alexpolovt...@gmail.com>
>> wrote:
>>> 
>>> The voting has finished and the results are the following:
>>> 
>>> [+1 Allow]: 1
>>> [-1 Prohibit]: 5
>>> 
>>> Therefore it is decided to prohibit using Guava in Ignite 3 codebase,
>> even
>>> if it is included as a direct dependency. I will add this to the Ignite 3
>>> code style document (or similar) as soon as it is available.
>>> 
>>> On Thu, Sep 9, 2021 at 6:28 PM Alexei Scherbakov <
>>> alexey.scherbak...@gmail.com> wrote:
>>> 
>>>> I've checked Guava's feature list and came to a conclusion it's
>> usefulness
>>>> has been diminished by switching to base java 11.
>>>> 
>>>> -1 for general use, but we can use some code parts then needed.
>>>> 
>>>> 
>>>> 
>>>> 
>>>> 
>>>> ср, 8 сент. 2021 г. в 14:09, Вячеслав Коптилин <
>> slava.kopti...@gmail.com>:
>>>> 
>>>>> -1
>>>>> I am leaning toward -1 because of vulnerability issues (that is a
>>>> possible
>>>>> case in general).
>>>>> 
>>>>> Thanks,
>>>>> S.
>>>>> 
>>>>> ср, 8 сент. 2021 г. в 12:13, Andrey Mashenkov <
>>>> andrey.mashen...@gmail.com
>>>>>> :
>>>>> 
>>>>>> -1
>>>>>> Supporting few copy-pasted methods is much easier than support
>>>>> dependencies
>>>>>> compatibility.
>>>>>> 
>>>>>> On Tue, Sep 7, 2021 at 7:42 PM Zhenya Stanilovsky
>>>>>> <arzamas...@mail.ru.invalid> wrote:
>>>>>> 
>>>>>>> 
>>>>>>> Aleksandr, thanks for this activity.
>>>>>>> -1 from my side, all my decisions are in linked discussion.
>>>>>>> 
>>>>>>>> Dear Igniters,
>>>>>>>> 
>>>>>>>> In this thread
>>>>>>>> <
>>>>>>> 
>>>>>> 
>>>>> 
>>>> 
>> https://lists.apache.org/thread.html/r4120a03a2bf32098e54e21ae02e509b0d68f413bc7cc1f8f6d85c93d%40%3Cdev.ignite.apache.org%3E
>>>>>>>> 
>>>>>>>> we've been discussing the problems and opportunities of using Guava
>>>>>>>> < https://github.com/google/guava > in Ignite 3. We have agreed
>>>> that
>>>>> it
>>>>>>>> should be added as a shaded dependency, but we haven't decided
>>>> whether
>>>>>> to
>>>>>>>> allow using Guava methods in the Ignite codebase or not. Therefore I
>>>>>> would
>>>>>>>> like to propose a vote:
>>>>>>>> 
>>>>>>>> [+1 Allow]: allow using Guava methods, if justified.
>>>>>>>> [-1 Prohibit]: prohibit using all Guava methods.
>>>>>>>> 
>>>>>>>> The voting will commence on Monday, September 13th at 9:00 UTC. Also
>>>>>> feel
>>>>>>>> free to express your opinion in the original discussion thread.
>>>>>>>> 
>>>>>>>> --
>>>>>>>> With regards,
>>>>>>>> Aleksandr Polovtcev
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> --
>>>>>> Best regards,
>>>>>> Andrey V. Mashenkov
>>>>>> 
>>>>> 
>>>> 
>>>> 
>>>> --
>>>> 
>>>> Best regards,
>>>> Alexei Scherbakov
>>>> 
>>> 
>>> 
>>> --
>>> With regards,
>>> Aleksandr Polovtcev
>> 
>> 
> 
> -- 
> With regards,
> Aleksandr Polovtcev

Reply via email to