PR is merged. Let me know if there are any issues. Thanks! On Mon, Mar 27, 2023 at 6:37 PM Gael Yimen Yimga <yimeng...@gmail.com> wrote:
> Hello, > I just want to share a little bit here. Force pushes are considered > emergency operations. Allowing developers to run force pushes may overwrite > commits that other collaborators have spent days of work to produce. People > might also have merge conflicts or corrupted pull requests and force pushes > them can create a repository that is not in a good standing. > This article <https://www.git-tower.com/blog/force-push-in-git/> > summarizes > some knowledge on force pushes > Gael. > > > > > On Mon, 27 Mar 2023 at 03:31, Pavel Tupitsyn <ptupit...@apache.org> wrote: > > > Nikolay, to avoid expensive mistakes. > > We don't need force pushes or merge commits, it is easy to disallow them, > > so why not? > > > > On Mon, Mar 27, 2023 at 1:24 PM Николай Ижиков <nizhi...@apache.org> > > wrote: > > > > > Hello, Pavel. > > > > > > Why do we need any new restrictions? > > > > > > > 27 марта 2023 г., в 12:32, Pavel Tupitsyn <ptupit...@apache.org> > > > написал(а): > > > > > > > > Mirza, yes, I've created a ticket for ignite-3 as well: > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-19122 > > > > > > > > > > > > On Mon, Mar 27, 2023 at 12:27 PM Mirza Aliev <alievmi...@gmail.com> > > > wrote: > > > > > > > >> Thanks! Nice idea! > > > >> > > > >> I wonder if this changes work for ignite-3 repo as well? > > > >> > > > >> пн, 27 мар. 2023 г. в 12:47, Pavel Tupitsyn <ptupit...@apache.org>: > > > >> > > > >>> Igniters, > > > >>> > > > >>> I'm going to enable master branch protection: > > > >>> - Disallow force push (dangerous) > > > >>> - Disallow merge commits (against our workflow) > > > >>> > > > >>> Any objections? > > > >>> > > > >>> [1] https://github.com/apache/ignite/pull/10608 > > > >>> [2] https://issues.apache.org/jira/browse/IGNITE-19123 > > > >>> > > > >> > > > > > > > > >
