Vadim,

> Likewise, the `node unit list` command will list only node statuses so the
`nodeId` is redundant because it will be called on the particular node
endpoint.

I still don't understand about the `node unit list`. The suggested syntax is:

node unit list [nodeId [--version version]] [--status ...]

If nodeId is redundant so how will the CLI know a target node? It
means that we have to specify the node. But `nodeId` is not mandatory.
I'm confused. It seems that the suggested syntax is not correct.

On Thu, May 25, 2023 at 6:40 PM Vadim Pakhnushev
<vpakhnus...@unison.team> wrote:
>
> The `nodeId` parameter is not required for the `cluster unit list` because
> we will list only cluster statuses.
> Likewise, the `node unit list` command will list only node statuses so the
> `nodeId` is redundant because it will be called on the particular node
> endpoint.
>
> On Thu, May 25, 2023 at 6:18 PM Andrey Gura <ag...@apache.org> wrote:
>
> > Hi, Vadim!
> >
> > Why is the `nodeId` parameter not required in the suggested syntax of
> > `cluster unit list` and `node unit list` commands?
> >
> > What does the `nodeId` parameter mean in the `cluster unit list` command?
> >
> >
> > On Thu, May 25, 2023 at 12:34 PM Vadim Pakhnushev
> > <vpakhnus...@unison.team> wrote:
> > >
> > > Hi Andrey!
> > >
> > > I have a small suggestion regarding the design of the CLI commands.
> > > Since we already have a cluster/node namespaces in the CLI, I'd suggest
> > > moving the deploy/undeploy/list commands to the cluster subcommand, and
> > > rather than using --node option to list the units on the particular node,
> > > use node namespace for the list command which will be operating on the
> > node
> > > level.
> > > So the whole list of commands would be:
> > > cluster unit deploy/undeploy - stay the same
> > > cluster unit list [nodeId [--version version]] [--status ...] - without
> > the
> > > --node option
> > > node unit list [nodeId [--version version]] [--status ...] - same
> > filters,
> > > but will show the node unit statuses rather than cluster statuses.
> > >
> > > WDYT?
> > >
> > > Thanks,
> > > Vadim
> > >
> > > On Tue, May 23, 2023 at 8:19 PM Andrey Gura <ag...@apache.org> wrote:
> > >
> > > > Hi, Igniters!
> > > >
> > > > Please take a look at the proposal for Code Deployment functionality
> > > > in Apache Ignite 3 [1].
> > > >
> > > > Thanks for any feedback!
> > > >
> > > > 1.
> > > >
> > https://cwiki.apache.org/confluence/display/IGNITE/IEP-103%3A+Code+Deployment
> > > >
> >

Reply via email to