[
https://issues.apache.org/jira/browse/IGNITE-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289599#comment-14289599
]
Dmitriy Setrakyan edited comment on IGNITE-49 at 1/23/15 6:00 PM:
------------------------------------------------------------------
Nikolai,
I saw that you have implemented the fix, but I am still seeing inconsistencies:
# What is the difference between {{ClusterMetrics}} and {{ClusterNodeMetrics}}?
This two APIs seem identical to me.
# {{ClusterNodeMetrics}} is not an MxBean, but has the MxBean annotations.
This seems wrong.
# {{ClusterNodeMetricsMxBean}} is located in the {{org.apache.ignite.internal}}
package, while {{IgniteCacheMxBean}} is located in public package. I think all
MxBeans should be public.
# All the APIs under {{org.apache.ignite.cache}} package start with {{Cache}}
prefix, while the {{IgniteCacheMxBean}} does not. We should follow the naming
conventions for consistency.
was (Author: dsetrakyan):
Nikolai,
I saw that you have implemented the fix, but I am still seeing inconsistencies:
# What is the difference between {{ClusterMetrics}} and {{ClusterNodeMetrics}}?
This two APIs seem identical to me.
# {{ClusterNodeMetrics}} is not an MxBean, but has the MxBean annotations.
This seems wrong.
# {{ClusterNodeMetricsMxBean}} is located in the {{org.apache.ignite.internal}}
package, while {{IgniteCacheMxBean}} is located in public package. I think all
MxBeans should be public.
# All the APIs under {{org.apache.ignite.cache}} package start with {{Cache}}
prefix, while the {{IgniteCacheMxBean}} is not. We should follow the naming
conventions for consistency.
> Implement statistics and management
> ------------------------------------
>
> Key: IGNITE-49
> URL: https://issues.apache.org/jira/browse/IGNITE-49
> Project: Ignite
> Issue Type: Sub-task
> Components: cache
> Reporter: Semen Boikov
> Assignee: Nikolay Tikhonov
> Fix For: sprint-1
>
> Attachments: ignite-49.patch
>
>
> See CacheMXBean, CacheStatisticsMXBean. Note: statistics/management can be
> enabled/disabled at runtime, also see spec '12.4. Statistics Effects of Cache
> Operations', need to check if it is consistent with current GridGain metrics.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
