I agree with renaming. If it is possible, can you make the change in a
separate branch and let me take a look?

D.

On Wed, Feb 4, 2015 at 1:27 AM, Vladimir Ozerov <[email protected]>
wrote:

> Folks,
>
> Currently "o.a.i.c.ClientConnectionConfiguration" class has lots of
> properties and we have a plan to review/refactor them.
>
> Here is my proposal on that:
> 1) Almost all properties have "rest" and "tcp" in their names. Let's remove
> these prefixes altogether. E.g.: "restTcpSelectorCount" -> "selectorCount".
> 2) Rename "clientMessageInterceptor" to "messageInterceptor"
> 3) Remove "restAccessibleFolders" and corresponding client "LOG" command.
> 4) Remove all mirrored (and already deprecated) properties from
> IgniteConfiguration as backward compatibility is not a concern for initial
> release.
>
> It appears that none other properties can be removed from this class
> because Memcached client use binary protocol and may potentially need any
> of them.
>
> Any comments?
>
> Vladimir.
>

Reply via email to