I think that having annotations only on public API is ok. @NotNull and @Contract seem to be extra effort.
Sergi 2015-02-09 9:33 GMT+03:00 Dmitriy Setrakyan <[email protected]>: > I generally found myself suppressing IDE warnings whenever these > annotations are used. Personally, I would not, but I would want to hear > what others think as well. > > D. > > On Sun, Feb 8, 2015 at 10:29 PM, Sergey Evdokimov <[email protected] > > > wrote: > > > Whats about @NotNull and @Contract annotations? Can we use its in our > code? > > > > On Mon, Feb 9, 2015 at 8:02 AM, Konstantin Boudnik <[email protected]> > wrote: > > > > > Sounds like a good idea. In my experience having @Nullable for returns > > is a > > > good thing, as it quickly let a user of the API to see what's the > > contract. > > > > > > Cos > > > > > > On Sun, Feb 08, 2015 at 04:36PM, Dmitriy Setrakyan wrote: > > > > Hi Igniters, > > > > > > > > I want to revisit the use of the @Nullable annotation within the > > project. > > > > What I am noticing more and more, is that @Nullable annotation just > > > causes > > > > extra warnings in IDE, especially on public API, causing most of the > > > users > > > > and developers to disable it. > > > > > > > > I want to propose the following policy: > > > > - Use @Nullable for method parameters on public API for documentation > > > > purposes. > > > > - Do not use @Nullable for return types on public API to avoid > > > unnecessary > > > > warnings. > > > > - Do not use @Nullable within internal implementation logic to avoid > > > > unnecessary clutter in code. > > > > > > > > Thoughts? > > > > > > > > D. > > > > > >
