[ 
https://issues.apache.org/jira/browse/IGNITE-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yakov Zhdanov reassigned IGNITE-11:
-----------------------------------

    Assignee: Sergey Evdokimov  (was: Yakov Zhdanov)

Sergey

Generally I like the implementation

However
# IgniteUtils has a lot of code style violations
# I think you should use completionService and submit callables returning 
tuple. code will be more elegant
# we should wait for all threads stop after shutting executor down

Pls fix and resubmit

> Discovery takes a lot of time on Windows if DescoverySpi contains several 
> hosts and several ports per host
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-11
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11
>             Project: Ignite
>          Issue Type: Task
>          Components: general
>            Reporter: Yakov Zhdanov
>            Assignee: Sergey Evdokimov
>              Labels: wait_for_review
>             Fix For: sprint-2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to