Hi Artem,
I've changed the implementation for the module ( IGNITE-788 branch ) in
according with the IgniteJcl implementation. I think that IGNITE_QUITE sys
variabile should not be used in the addConsoleAppenderIfNeeded , as well.
replace this
boolean quiet = Boolean.valueOf(System.getProperty(IGNITE_QUIET,
"true"));
with
boolean quiet = isQuite();
In additions, I'd like to ask you some hints about the new implementations
of the IgniteLogger with log4j2.
We need to insert some informations about the currente nodeId, I'd like to
implement this feature by configuration in this way:
<Appender type="File" name="File"
fileName="C:/work/log/ignite-${sys:nodeid}.log">
When nodeid is a System properties setted in thi way:
System.setProperty("nodeid", ignite.cluster().localNode().id());
Let me know any suggestions.
Thank you, Gianfranco
2015-05-20 14:18 GMT+02:00 Artiom Shutak <[email protected]>:
> Hi, Igniters,
>
> In process of investigation of a user request "Disable ignite console logs"
> (
>
> http://apache-ignite-users.70518.x6.nabble.com/Disable-ignite-console-logs-td310.html#a330
> ),
> I've found inconsistency at implementations of IgniteLogger.isQuiet():
> - Javadoc of the method says:
> /**
> * Tests whether {@code info} and {@code debug} levels are turned off.
> *
> * @return Whether {@code info} and {@code debug} levels are turned
> off.
> */
> - IgniteJclLogger.isQuiet() implementation corresponds to javadoc.
> - isQuiet() implementations for Log4JLogger and JavaLogger don't correspond
> to javadoc and "quite" option related to IGNITE_QUITE system variable.
>
> For me, the implementation of Log4JLogger is better and we should change
> javadoc and change implementation of IgniteJclLogger accordingly. I've
> filed a bug on it: https://issues.apache.org/jira/browse/IGNITE-923.
>
> Any objections?
>
> -- Artem --
>
