Gianfranco, See my comments at the jira.
-- Artem -- On Wed, Jul 1, 2015 at 12:53 PM, Gianfranco Murador < [email protected]> wrote: > forwarding the email to dev list > > 2015-06-30 22:35 GMT+02:00 Gianfranco Murador < > [email protected]>: > >> Hi Artiom, I have no difficult for the first point. I can format the >> patch again with Eclipse. >> For the second point I can change the pattern layout in the log4j2 config >> as in log4j, but it remains very difficult to change the name of the log >> file at runtime without using a Route Appender. From one point of view, the >> implementation is simple, on the other hand there is always a default log >> where will be placed the lines when thread context doesn't have a nodeid. >> In attachment to the ticket you can fine an example (file patch.zip). >> Let me know if it is ok for you and if it needs further explanation. >> Regards, Gianfranco >> >> >> On Jun 30, 2015 8:51 PM, "Artiom Shutak" <[email protected]> wrote: >> >>> Hi Gianfranco, >>> >>> I've done a review of ignite-788. >>> >>> Can you please look on my review (see comment at jira and new attached >>> patch file). Let me know what you think. >>> >>> -- Artem -- >>> >> >
