On 28.07.2015 12:12, Yakov Zhdanov wrote: > I am for RTC. > > Agree with Val, that significant part of the concurrency issues are very > hard to catch with CI. They are caught on review (and some unfortunately > slip through). And Sergi's points seems very valid to me - complex changes > should be reviewed to make the best effort to avoid issues of any type. > > I would encourage everyone to request review if: > > - core logic changed. Although it is very hard to define, but > communication, discovery, cache, compute, deployment, continuous processes > are on the list. > - public APIs > - new feature completed (in most cases it causes changes to public API) > > The following can be committed to master right-away: > > - Javadocs > - Comments > - Typos > - Fixes to tests > > Let's summarize the points to some kind of guideline/hints and put it on > wiki.
I agree about the guidelines, just don't make them rules. I still maintain that the committer should be trusted to know when a prior review is needed. -- Brane
