Now I also agree with Semyon about nodeName thread names are very important debug feature.
On Wed, Aug 19, 2015 at 3:28 PM, Denis Magda <[email protected]> wrote: > Fully share Semyon's opinion: renaming to 'nodeName'. > > > > On 8/19/2015 11:22 AM, Semyon Boikov wrote: > >> There is already convinient way to distinguish nodes, why we are trying to >> invent something new? >> >> Also note that now node name is added to the names of all ignite threads, >> so when I run test from logs I can quickly understand where operation is >> executed, I do not want to drop this feature. >> >> On Wed, Aug 19, 2015 at 11:04 AM, Alexey Kuznetsov < >> [email protected]> >> wrote: >> >> Semen, it is possible to distinguish nodes via attributes (put some marker >>> to node attributes) ? >>> >>> On Wed, Aug 19, 2015 at 2:57 PM, Semyon Boikov <[email protected]> >>> wrote: >>> >>> In my opinion this propery just should be renamed to 'nodeName'. >>>> Possibility to set node name is very useful in our tests. As I see >>>> 'setNodeId' is already deprecated in IgniteConfiguration, how we will >>>> distinguish nodes in our tests? >>>> >>>> On Tue, Aug 18, 2015 at 1:42 PM, Yakov Zhdanov <[email protected]> >>>> wrote: >>>> >>>> Guys, >>>>> >>>>> I am thinking of deprecating this property. >>>>> >>>>> 1. nodes with different grid names can discover each other and build a >>>>> single topology. I heard that some of the users expected that there >>>>> >>>> would >>> >>>> be separate topologies >>>>> 2. Locally started nodes can be accessed via their IDs through Ignition >>>>> interface. >>>>> 3. Internally gridName is used in components serialization and >>>>> deserializaiton, but this is very unreliable and can be broken if >>>>> >>>> different >>>> >>>>> names are configured within the same topology - >>>>> https://issues.apache.org/jira/browse/IGNITE-10 >>>>> >>>>> Thoughts? >>>>> >>>>> --Yakov >>>>> >>>>> >>> >>> -- >>> Alexey Kuznetsov >>> GridGain Systems >>> www.gridgain.com >>> >>> > -- Alexey Kuznetsov GridGain Systems www.gridgain.com
