Ahh no, it doesn't do that. Currently you have to go back and check the job status yourself.
I guess we could change the "dry run" part only to be about doing the commit portion and still always mark whether verified. On Fri, Jun 1, 2018 at 11:43 AM, Todd Lipcon <[email protected]> wrote: > On Fri, Jun 1, 2018 at 11:37 AM, Michael Brown <[email protected]> wrote: > > > Thanks for taking an interest! > > > > Is https://jenkins.impala.io/job/gerrit-verify-dryrun-external/ suitable > > for you? It's open to all contributors. It's just a wrapper around > > gerrit-verify-dryrun, sans commit-after-passing-build bit. > > > > Will this give the proper "+1 verified" mark on a gerrit such that it can > be committed? > > -Todd > > > > On Fri, Jun 1, 2018 at 11:35 AM, Todd Lipcon <[email protected]> wrote: > > > > > Hey folks, > > > > > > Would someone mind generating an account for me on the Impala jenkins > > > server so I can run gerrit verify jobs? > > > > > > Though I'm officially a committer (due to participation as a mentor > > during > > > incubation) I'm not yet an experienced patch contributor, so I'll be > > > prudent with my review/commit privileges. > > > > > > Thanks > > > -Todd > > > -- > > > Todd Lipcon > > > Software Engineer, Cloudera > > > > > > > > > -- > Todd Lipcon > Software Engineer, Cloudera >
