gerrit-code-review-checks seems a bit unhappy with the change, e.g. https://jenkins.impala.io/job/gerrit-code-review-checks/1963/artifact/https%3A%5E%5Ejenkins.impala.io%5Ejob%5Eclang-tidy-ub1604%5E5041%5E/*view*/
+ ./buildall.sh -skiptests -tidy -so -noclean + echo 'tidy build failed; See /home/ubuntu/tidylog.txt for full tidy build output. Guess:' tidy build failed; See /home/ubuntu/tidylog.txt for full tidy build output. Guess: + grep ': error: ' /home/ubuntu/tidylog.txt /home/ubuntu/Impala-lzo/hdfs-lzo-text-scanner.cc:140:17: error: ‘class impala::HdfsScanNodeBase’ has no member named ‘UpdateRemainingScanRangeSubmissions’ /home/ubuntu/Impala-lzo/hdfs-lzo-text-scanner.cc:168:14: error: ‘class impala::HdfsScanNodeBase’ has no member named ‘UpdateRemainingScanRangeSubmissions’ /home/ubuntu/Impala-lzo/hdfs-lzo-text-scanner.cc:169:59: error: no matching function for call to ‘impala::HdfsScanNodeBase::AddDiskIoRanges(std::vector<impala::io::ScanRange*>&)’ /home/ubuntu/Impala-lzo/hdfs-lzo-text-scanner.cc:200:49: error: no matching function for call to ‘impala::HdfsScanNodeBase::AddDiskIoRanges(std::vector<impala::io::ScanRange*>)’ On Fri, Feb 1, 2019 at 1:20 PM Philip Zeyliger <[email protected]> wrote: > Hi folks, > > I just pushed > > https://gitbox.apache.org/repos/asf?p=impala.git;a=commit;h=a8e30506aafef14646d95a56fb87cf7c28d259d6 > and > > https://github.com/cloudera/impala-lzo/commit/dccb1be88a5e237b06ae69cd99b048a38d9f024b > to tackle IMPALA-7980. If you're working on master, and you have > ../Impala-lzo checked out, you'll need to pull that repo. There's also a > divergence now for Impala-lzo between branches, so if you're still working > on 2.x (say), you'll need to figure out how to manage that. > > Please let me know if you run into issues; I'll be happy to help. > > -- Philip >
