Unsubscribe -----Original Message----- From: Zoltán Borók-Nagy <borokna...@apache.org> Sent: Monday, June 29, 2020 6:41 AM To: dev@impala <dev@impala.apache.org> Subject: Re: IMPALA-5078
Hey Sean, Thanks for your interest in the project. I assigned the task to you. I think the jira is about to move all tests related to string functions <https://impala.apache.org/docs/build/html/topics/impala_string_functions.html#string_functions> to a separate test file. If there are further questions, we can discuss those during the code review. Hope this helps, cheers, Zoltan On Sat, Jun 27, 2020 at 3:02 AM S Y117 <sean.yeh...@gmail.com> wrote: > Hi Apache Impala Dev Team, > > I was hoping to contribute to Apache Impala. As a first-time > contributor, I would like to work on ticket 5078, Break up > expr-test.cc, since it is tagged for newbies and ramp-up. > > The ticket suggests moving string instructions to a new separate file, > expr-strint-test.cc. However, I am a little confused as to what a > string instruction is. Is a string instruction any instruction that > mutates a string? > > 1. If a test concatenates two strings, would I move it to the new file? > 2. Do I move all functions that return strings? > > If I am able to work on this ticket, my username is sy117. > > Thank you, > > Sean >
