Oops, I thought I should use the tree hash of a "real" commit. Thanks for the clarification!
On Mon, Jul 5, 2021 at 9:34 PM Zoltán Borók-Nagy <borokna...@apache.org> wrote: > Hi Quanlong, > > Thanks for doing all of this. > I executed https://jenkins.impala.io/job/release-test-ub1604/45/console > but > it failed when it checked the git tree hash. > > Seems like b51f271f16e7a9c51a7652dc11009bb4193de0fb is the tree hash for > the current 'apache/branch-4.0.0 (a702d2d4)'. > > Tag 4.0.0-rc7 is ahead of branch-4.0.0 with one commit (the one that > modified save-version.sh). > > So I think the tree-hash for 4.0.0-rc7 should > be 113c0c0f59a3e260884c18cbc5957af41ddffabd > > Cheers, > Zoltan > > > On Mon, Jul 5, 2021 at 5:24 AM Jim Apple <apa...@jbapple.com> wrote: > > > Nevermind; found it. I needed to do git fetch -t, not my usual git > > fetch. :-) > > > > On Sun, Jul 4, 2021 at 7:04 PM Jim Apple <apa...@jbapple.com> wrote: > > > > > I don't see the 4.0.0-rc7 tag in git. Is that just me? > > > > > > On Sun, Jul 4, 2021 at 6:27 PM Quanlong Huang <huangquanl...@gmail.com > > > > > wrote: > > > > > >> Hi all, > > >> > > >> Finally, this is a vote for Impala 4.0.0! It's the 7th candidate since > > >> previous candidates were blocked for different reasons. > > >> > > >> The artifacts for testing can be downloaded from: > > >> https://dist.apache.org/repos/dist/dev/impala/4.0.0/RC7/ > > >> Git tag: 4.0.0-rc7 > > >> https://github.com/apache/impala/releases/tag/4.0.0-rc7 > > >> Tree hash: b51f271f16e7a9c51a7652dc11009bb4193de0fb > > >> > > >> Please vote +1 or -1. -1 votes should be accompanied by an explanation > > of > > >> the reason. Only PMC members have binding votes, but other > > >> community members are encouraged to cast non-binding votes. This vote > > will > > >> pass if there are 3 binding +1 votes and more binding +1 votes than -1 > > >> votes. > > >> > > >> This wiki page describes how to check the release before you vote: > > >> > > >> > > > https://cwiki.apache.org/confluence/display/IMPALA/How+to+Release#HowtoRelease-HowtoVoteonaReleaseCandidate > > >> > > >> I tested this by running exhaustive jobs for both with/without > > >> LocalCatalog > > >> mode, i.e. ubuntu-16.04-from-scratch and > ubuntu-16.04-dockerised-tests. > > >> (Unfortunately, they have been flushed out from the Jenkins history > so I > > >> can't paste the links here) > > >> > > >> Thanks, > > >> Quanlong > > >> > > > > > >
