Hi guys, Thanks for your feedback! Replied in thread:
> I think the key to whether release a 4.1.1 branch is how many break changes from 4.1.0 to 4.2.0, and how important the ratio of user 4.1.0. For the second question, maybe we can create a questionnaire. There should be no breaking changes from 4.1.0 to 4.2.0 since 4.2.0 does not bump the major version. I've heard some users that tried to upgrade to 4.1.0 and hitted some issues. Releasing 4.1.1 will avoid new users hitting the same problem. > The Apache Hive 3 related one also doesn't seem critical, as it is a part of an ongoing effort AFAIK (if there are actually people who use Impala 4.1 with Apache HMS, then it is a different story). I also heard some users maintaining their internal branches with the Apache Hive 3 patches on Impala-3.4 or 4.0. So I think it'd be nice if we can save their effort in 4.1. I'll proceed to create a 4.1.1 branch: https://github.com/stiga-huang/impala/tree/branch-4.1.1 It has passed CORE tests: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17162/ https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/6089/ I'll also cherrypick 0ee5f8084f1bb34fc261c729f736ac093ba59c41 as Michael suggested. e00a2cbd818dea45a7c6f2fac579af4389d42759 will be ignored since it's a fix on a new feature (IMPALA-1682) added in 4.2.0. Thanks, Quanlong On Thu, Aug 4, 2022 at 4:29 AM Michael Smith <michael.sm...@cloudera.com> wrote: > Can you include > > https://github.com/apache/impala/commit/e00a2cbd818dea45a7c6f2fac579af4389d42759 > and > > https://github.com/apache/impala/commit/0ee5f8084f1bb34fc261c729f736ac093ba59c41 > ? > They cover small bugs in impala-shell Python 3 support. > > On Tue, Aug 2, 2022 at 8:22 AM Csaba Ringhofer <csringho...@cloudera.com> > wrote: > > > 4.1.1 has some very important fixes, so I agree with the release if there > > are actually people out there who use 4.1 > > > > >and do code review for resolving such cherrypick conflicts. > > If these conflicts are tricky, then it may make sense to postpone them > till > > 4.2. > > The Iceberg related ones do not seem fatal, and if there are Iceberg + > > Impala users, I think that they would benefit greatly from a 4.2 release > as > > there are several Iceberg improvements. > > The Apache Hive 3 related one also doesn't seem critical, as it is a > part > > of an ongoing effort AFAIK (if there are actually people who use Impala > 4.1 > > with Apache HMS, then it is a different story). > > > > > > On Tue, Aug 2, 2022 at 2:23 PM Zoltán Borók-Nagy < > borokna...@cloudera.com> > > wrote: > > > > > +1 on doing a 4.1.1 release. There are important bug fixes since 4.1.0. > > > > > > Thanks, > > > Zoltan > > > > > > > > > On Tue, Aug 2, 2022 at 4:29 AM Xiang Yang <yx91...@126.com> wrote: > > > > > > > Hi Quanlong, > > > > Thank you for your efforts, I think the key to whether release a > 4.1.1 > > > > branch is how many break changes from 4.1.0 to 4.2.0, and how > important > > > the > > > > ratio of user 4.1.0. For the second question, maybe we can create a > > > > questionnaire. > > > > > > > > > > > > > > > > > > > > Thanks, > > > > Xiang Yang > > > > > > > > > > > > At 2022-08-01 17:41:12, "Quanlong Huang" <huangquanl...@gmail.com> > > > wrote: > > > > >Hi team, > > > > > > > > > >Impala 4.1.0 was released in June. There are a bunch of bug fixes > > after > > > > >that. It'd be nice to release 4.1.1 with them. > > > > > > > > > >I just tried cleanly cherrypick as more fixes as possible to > > > branch-4.1.0. > > > > >Here are what I got: > > > > >https://github.com/stiga-huang/impala/commits/branch-4.1.1 > > > > > > > > > >There are some fixes that have cherrypick conflicts: > > > > > > > > > >1a1536bd1d0162a168877a6f33dd75f9544a82f3 IMPALA-11346: Migrated > > > > partitioned > > > > >Iceberg tables might return ERROR when WHERE condition is used on > > > > partition > > > > >column > > > > >4174ff5ea6a1b413a6218d26bbb7cf20809623cd IMPALA-11320: SHOW > PARTITIONS > > > on > > > > >Iceberg table doesn't list the partitions > > > > >8d034a2f7cd2f68714e83b28335b3baf18823d7c IMPALA-11034: Resolve > schema > > of > > > > >old data files in migrated Iceberg tables > > > > >e1fea843ea2654d3acfef152e1a073dbef91aa9c IMPALA-11433: Remove > > misleading > > > > >bucketing info from DESCRIBE FORMATTED output for Iceberg tables > > > > >1d16367afb1e520bae5992c1e6c92b4fb41d2655 IMPALA-10871 (part 2): > Apache > > > > Hive > > > > >3: fixes for dataset loading > > > > > > > > > >I haven't merged them yet. > > > > > > > > > >Do you think it makes sense to create a 4.1.1 branch? So we can > > prepare > > > > the > > > > >4.1.1 release and do code review for resolving such cherrypick > > > conflicts. > > > > > > > > > >Thanks, > > > > >Quanlong > > > > > > > > > >
