wzhou-code commented on code in PR #60:
URL: https://github.com/apache/impala/pull/60#discussion_r1364990392
##########
java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java:
##########
@@ -30,25 +30,34 @@
import java.util.Properties;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;
+import java.util.UUID;
import javax.sql.DataSource;
import org.apache.commons.dbcp2.BasicDataSource;
import org.apache.commons.dbcp2.BasicDataSourceFactory;
+import org.apache.impala.common.InternalException;
import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.impala.common.FileSystemUtil;
import org.apache.impala.extdatasource.jdbc.conf.JdbcStorageConfig;
import org.apache.impala.extdatasource.jdbc.conf.JdbcStorageConfigManager;
import
org.apache.impala.extdatasource.jdbc.exception.JdbcDatabaseAccessException;
import org.apache.impala.service.FeSupport;
import org.apache.impala.thrift.TCacheJarResult;
import org.apache.impala.thrift.TErrorCode;
import org.apache.impala.thrift.TStatus;
+import org.apache.impala.thrift.TBackendGflags;
+import org.apache.impala.service.BackendConfig;
Review Comment:
add import in alphabet order
##########
java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java:
##########
@@ -296,4 +311,28 @@ protected int getFetchSize(Configuration conf) {
.getInt(JdbcStorageConfig.JDBC_FETCH_SIZE.getPropertyName(),
DEFAULT_FETCH_SIZE);
}
+ protected String getJdbcDriverFromUri(String driverUrl, String localLibPath)
+ // protected TCacheJarResult createWithLocalPath(String localLibPath,
Function fn)
+ throws InternalException {
+ Path localJarPath = null;
+ String uri = driverUrl;
+ String localJarPathString = null;
Review Comment:
indent spaces
##########
java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java:
##########
@@ -30,25 +30,34 @@
import java.util.Properties;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;
+import java.util.UUID;
import javax.sql.DataSource;
import org.apache.commons.dbcp2.BasicDataSource;
import org.apache.commons.dbcp2.BasicDataSourceFactory;
+import org.apache.impala.common.InternalException;
import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.impala.common.FileSystemUtil;
import org.apache.impala.extdatasource.jdbc.conf.JdbcStorageConfig;
import org.apache.impala.extdatasource.jdbc.conf.JdbcStorageConfigManager;
import
org.apache.impala.extdatasource.jdbc.exception.JdbcDatabaseAccessException;
import org.apache.impala.service.FeSupport;
import org.apache.impala.thrift.TCacheJarResult;
import org.apache.impala.thrift.TErrorCode;
import org.apache.impala.thrift.TStatus;
+import org.apache.impala.thrift.TBackendGflags;
+import org.apache.impala.service.BackendConfig;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import com.google.common.cache.Cache;
import com.google.common.cache.CacheBuilder;
import com.google.common.cache.RemovalListener;
+import com.google.common.base.Preconditions;
Review Comment:
add import in alphabet order
##########
java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java:
##########
@@ -231,15 +240,18 @@ protected void initializeDatabaseSource(Configuration
conf)
BasicDataSourceFactory.createDataSource(props);
// Put jdbc driver to cache
String driverUrl = props.getProperty("driverUrl");
- TCacheJarResult cacheResult = FeSupport.CacheJar(driverUrl);
- TStatus cacheJarStatus = cacheResult.getStatus();
- if (cacheJarStatus.getStatus_code() != TErrorCode.OK) {
+ String localPath =
BackendConfig.INSTANCE.getBackendCfg().local_library_path;
+
+ // TCacheJarResult cacheResult = FeSupport.CacheJar(driverUrl);
+ String driverLocalPath = getJdbcDriverFromUri(driverUrl,
localPath);
+ // TStatus cacheJarStatus = cacheResult.getStatus();
+ // if (cacheJarStatus.getStatus_code() != TErrorCode.OK) {
Review Comment:
indent space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@impala.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
