Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3085: Unregister data sinks' MemTrackers at their Close() functions. ......................................................................
Patch Set 2: (2 comments) Do you know why we can't auto unregister all mem trackers? That seems easier than manually unregistering them. http://gerrit.cloudera.org:8080/#/c/2314/2/be/src/exec/hbase-table-sink.cc File be/src/exec/hbase-table-sink.cc: Line 103: ExprContext::FreeLocalAllocations(output_expr_ctxs_); Same as other comment, this shouldn't be necessary. http://gerrit.cloudera.org:8080/#/c/2314/2/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: Line 627: ExprContext::FreeLocalAllocations(partition_key_expr_ctxs_); I don't think these FreeLocalAllocations() calls are necessary, they will happen when the exprs are closed. This API is exposed so it can be called during query execution to free unneeded memory. -- To view, visit http://gerrit.cloudera.org:8080/2314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aec82150a933dc2b261beff41f5f4f022501bfb Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-HasComments: Yes
