Henry Robinson has posted comments on this change. Change subject: IMPALA-3095: Add configurable whitelist of authorized internal principals ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2334/2/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: Line 97: C > nit: formatting, space Done Line 414: split(whitelist, FLAGS_internal_principals_whitelist, is_any_of(",")); > Since we default to hdfs, we always would get 'hdfs' here. But if the defau Good point - I remove empty whitelisted user strings. I think that fixes both cases. -- To view, visit http://gerrit.cloudera.org:8080/2334 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If828e86c99c3c398319953b1d3b33d5e3af200da Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
