Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3071: Fix assignment of On-clause predicates belonging to an inner join. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2309/2/fe/src/main/java/com/cloudera/impala/analysis/Analyzer.java File fe/src/main/java/com/cloudera/impala/analysis/Analyzer.java: Line 1308: return tupleIds.containsAll(onClauseTableRef.getAllTupleIds()); isn't this the same as 'return false;'? - we know that tids.size() == 1 - the join node will materialize >1 tids -- To view, visit http://gerrit.cloudera.org:8080/2309 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffef7718679d48f866fa90fd3257f182cbb385ae Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
