Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3103: More efficient Bloom Filter serialisation. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2359/1/be/src/util/bloom-filter.cc File be/src/util/bloom-filter.cc: Line 65: DCHECK_EQ(thrift.directory.size(), 1ll << (log_num_buckets_ + LOG_BUCKET_BYTE_SIZE)); 1ll << .. shows up frequently, create a helper function in .h Line 82: thrift->directory.resize(1ll << (log_num_buckets_ + LOG_BUCKET_BYTE_SIZE)); string dir_string(static_cast<char*>(directory_), ...); dir_string.swap(thrift->directory); ? -- To view, visit http://gerrit.cloudera.org:8080/2359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5237e776a197cb2696675dbbe0359e751605ed84 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
