Bharath Vissapragada has submitted this change and it was merged. Change subject: IMPALA-1702: Dump fragment's thrift descriptor when a table's partition info is corrupt ......................................................................
IMPALA-1702: Dump fragment's thrift descriptor when a table's partition info is corrupt This patch stores the fragment's TExecPlanFragmentParams, which is the top-level thrift struct for the fragment, in the runtime state. We store the fragment params so we can dump everything sent from the FE to the BE when we detect a problem. This patch does so when a call to HdfsTable::GetPartition() returns NULL, which we never expect to happen. This will give us more information in the case of crashes caused by IMPALA-1702 or similar bugs that cause bad partition IDs to be sent to the BE. Change-Id: Ibb2ff05810cfd5f7aa3e210555d9d69361e8272a Reviewed-on: http://gerrit.cloudera.org:8080/456 Reviewed-by: Juan Yu <[email protected]> Tested-by: Internal Jenkins (cherry picked from commit 8e92dd70e7af61934f08e0cafeeb1d62779124b4) (cherry picked from commit 1fc8fc061f74eca98ff992c8c6c5439737eb8a41) Reviewed-on: http://gerrit.cloudera.org:8080/2349 Reviewed-by: Bharath Vissapragada <[email protected]> Tested-by: Bharath Vissapragada <[email protected]> --- M be/src/exec/hdfs-scan-node.cc M be/src/exprs/expr-test.cc M be/src/runtime/buffered-block-mgr-test.cc M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/coordinator.cc M be/src/runtime/data-stream-test.cc M be/src/runtime/descriptors.h M be/src/runtime/plan-fragment-executor.cc M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h M be/src/util/debug-util.h 11 files changed, 61 insertions(+), 39 deletions(-) Approvals: Bharath Vissapragada: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/2349 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb2ff05810cfd5f7aa3e210555d9d69361e8272a Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.2.0_5.4.x Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]>
