Huaisi Xu has submitted this change and it was merged. Change subject: IMPALA-2643: Prevent migrating incorrectly inferred identity predicates into inline views. ......................................................................
IMPALA-2643: Prevent migrating incorrectly inferred identity predicates into inline views. Inferred predicates implicitly referring to the same expr can be migrated into an inline view where the post-substitution predicate is an identity predicate. If such a predicate is assigned to an plan node later, it incorrectly drops NULLs. Change-Id: Id40524b30799d1ac994c0a44efcc1acce4ad1daf Reviewed-on: http://gerrit.cloudera.org:8080/1720 Reviewed-by: Huaisi Xu <[email protected]> Tested-by: Internal Jenkins (cherry picked from commit 0d2950200bfcee7fcbc888dc770acd0b873c98db) Reviewed-on: http://gerrit.cloudera.org:8080/2339 Tested-by: Huaisi Xu <[email protected]> --- M fe/src/main/java/com/cloudera/impala/analysis/Analyzer.java M fe/src/main/java/com/cloudera/impala/analysis/BinaryPredicate.java M fe/src/main/java/com/cloudera/impala/planner/SingleNodePlanner.java M testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test 4 files changed, 72 insertions(+), 19 deletions(-) Approvals: Huaisi Xu: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/2339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id40524b30799d1ac994c0a44efcc1acce4ad1daf Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.2.0_5.4.x Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Juan Yu <[email protected]>
