Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3065: Register !empty() predicates as On-clause conjuncts. ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/2365/1/fe/src/main/java/com/cloudera/impala/analysis/CollectionTableRef.java File fe/src/main/java/com/cloudera/impala/analysis/CollectionTableRef.java: Line 103: // an empty result set. comment doesn't apply anymore. Line 108: // affect the result of this join (e.g., and not the whole FROM clause). hm, that's a bummer, it would be nice to register it directly as a scan predicate. http://gerrit.cloudera.org:8080/#/c/2365/1/testdata/workloads/functional-planner/queries/PlannerTest/nested-collections.test File testdata/workloads/functional-planner/queries/PlannerTest/nested-collections.test: Line 685: | | predicates: !empty(a.struct_array_col) what's the point of having it here? would the nlj even return anything if it's empty? -- To view, visit http://gerrit.cloudera.org:8080/2365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7236940057f6468b085ffb2c228c3146b102cea7 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
