Alex Behm has posted comments on this change. Change subject: IMPALA-3084: Cache the sequence of table ref and materialized tuple ids during analysis. ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/2367/2/fe/src/main/java/com/cloudera/impala/analysis/TableRef.java File fe/src/main/java/com/cloudera/impala/analysis/TableRef.java: Line 439: * and the TupleDescriptor (desc) of this table has been created. > update comment Done http://gerrit.cloudera.org:8080/#/c/2367/2/testdata/workloads/functional-planner/queries/PlannerTest/nested-collections.test File testdata/workloads/functional-planner/queries/PlannerTest/nested-collections.test: Line 763 > what happened here? This duplicate assignment was a combination of two bugs: First. the getAllTupleIds() bug, see Analyzer.canEvalAntiJoinedConjunct() lead us to not pick up the conjunct in the regular getHashLookupJoinConjuncts(). Second, we incorrectly created a hash conjunct inferred equivalence classes. Since the original conjunct was still unassigned, we picked it up again as an other join conjunct, I also fixed the incorrect inference based on equivalence classes now. Line 1746: | | predicates: o.o_orderkey IS NULL, o.o_orderstatus IS NOT DISTINCT FROM o_orderpriority > where did the 'is null' end up before? In the scan as well as the join. That was the bug. -- To view, visit http://gerrit.cloudera.org:8080/2367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I298b8695c9f26644a395ca9f0e86040e3f5f3846 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
