Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1822: Cleanup query profile log ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/2260/2/be/src/util/logging-support.cc File be/src/util/logging-support.cc: Line 98: path > as in the header, I think we need to pick a name that indicates it's a patt Done Line 112: > can you convert these tabs to spaces? Done Line 113: > same Done Line 130: > same. Done http://gerrit.cloudera.org:8080/#/c/2260/2/be/src/util/logging-support.h File be/src/util/logging-support.h: Line 34: DeleteOldLogs > nit: maybe nest this as a static fn in a LoggingSupport class since it's ki Done Line 34: path > path is a bit misleading as that sounds like a single file path, but this i Done -- To view, visit http://gerrit.cloudera.org:8080/2260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52430d192d27cdf9bc0d81f26a63048eaeec5d29 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
