Dan Hecht has posted comments on this change. Change subject: Test for IMPALA-2987 ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2306/3/be/src/exec/exchange-node.cc File be/src/exec/exchange-node.cc: Line 71: } can this be achieved using a WAIT DebugAction since this is associated with an exec-node? http://gerrit.cloudera.org:8080/#/c/2306/3/tests/custom_cluster/test_exchange_delays.py File tests/custom_cluster/test_exchange_delays.py: Line 32: relatively soon after the timeout. let's be more explicit about how these parameters were tuned -- something like what you said in your reply to Henry about in this case you want just the first batch or so to arrive <fill in the details> whereas the other case you want all batches to arrive before <fill in the details> -- To view, visit http://gerrit.cloudera.org:8080/2306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5f5746b6023c301bacfa305c525846cdde822c9 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
