Anuj Phadke has submitted this change and it was merged. Change subject: IMPALA-2264: fix edge cases for decimal/integer cast ......................................................................
IMPALA-2264: fix edge cases for decimal/integer cast Previously a bug allowed decimals to be cast to slightly smaller integer types, e.g. DECIMAL(3,0) with range [-999,999] could be cast to TINYINT with range [-128,127]. Decimals aside from this edge case (e.g. DECIMAL(2,0) and DECIMAL(4,0)) were handled correctly. This patch fixes the edge case and adds tests. Change-Id: I830e895e8aeb0b75de636a3b8c23ed3092f7136b Reviewed-on: http://gerrit.cloudera.org:8080/709 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Internal Jenkins (cherry picked from commit 2e86e678ec4590765d1306fee776d7c2cfddcbdd) Reviewed-on: http://gerrit.cloudera.org:8080/2344 Reviewed-by: Anuj Phadke <[email protected]> Tested-by: Anuj Phadke <[email protected]> --- M fe/src/main/java/com/cloudera/impala/catalog/ScalarType.java M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeExprsTest.java M fe/src/test/java/com/cloudera/impala/analysis/TypesUtilTest.java 3 files changed, 71 insertions(+), 7 deletions(-) Approvals: Anuj Phadke: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/2344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I830e895e8aeb0b75de636a3b8c23ed3092f7136b Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.2.0_5.4.x Gerrit-Owner: Anuj Phadke <[email protected]> Gerrit-Reviewer: Anuj Phadke <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
