Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor. ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/2203/6/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 698: if (UNLIKELY(!ConvertSlot(&val, reinterpret_cast<T*>(slot), pool))) return false; combine these two if-stmts using && Line 756: "ConvertSlot()", len, "StringValue")); here and elsewhere: should we use SetMemLimitExceeded() in order to get the mem-tracker reporting (LogUsage())? (Hopefully we can make that thing not have the side-effect of setting query_status_ soon) http://gerrit.cloudera.org:8080/#/c/2203/6/be/src/runtime/mem-pool.h File be/src/runtime/mem-pool.h: Line 166: /// NULL is reserved for allocation failures. any particular reason this has to be 4-bytes as opposed to 1-byte or 8-bytes? if the specific size isn't important, delete the "4-byte" since that can be easily inferred from the code and specifying it makes it sound significant. Line 213: int64_t is this all that's needed to make 64-bit allocations work? -- To view, visit http://gerrit.cloudera.org:8080/2203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic70400407b7662999332448f4d1bce2cc344ca89 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
