Henry Robinson has posted comments on this change. Change subject: IMPALA-3095: Add configurable whitelist of authorized internal principals ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/2360/1/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: Line 50: //#include "common/names.h" Remove if commented out Line 56: using boost::mt19937; : using boost::uniform_int; what are these used for? Line 414: it++ > nit: '++it' according to our style remove std::/ Prefer BOOST_FOREACH when C++11 is not available. Line 415: string& s = *it; indentation is wrong here. -- To view, visit http://gerrit.cloudera.org:8080/2360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If828e86c99c3c398319953b1d3b33d5e3af200da Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.2.0_5.4.x Gerrit-Owner: Anuj Phadke <[email protected]> Gerrit-Reviewer: Anuj Phadke <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
