Jim Apple has posted comments on this change. Change subject: IMPALA-2887: improve Bitmap with a fast mod ......................................................................
Patch Set 6: (1 comment) I'd suggest this be abandoned if we are no longer using modulo in bitmaps. http://gerrit.cloudera.org:8080/#/c/1907/6/be/src/benchmarks/fastmod-benchmark.cc File be/src/benchmarks/fastmod-benchmark.cc: Line 96: 12 2^17 - 1 -- To view, visit http://gerrit.cloudera.org:8080/1907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I812fa7cf1cb7e79fb25158cc139d86ddb03eb528 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Zuo Wang <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Zuo Wang <[email protected]> Gerrit-HasComments: Yes
