Alex Behm has posted comments on this change. Change subject: IMPALA-3084: Cache the sequence of table ref and materialized tuple ids during analysis. ......................................................................
Patch Set 7: (1 comment) There was an interesting failure related to now having the complete table ref ids in Analyzer.canEvalAntiJoinedConjunct(). That is now fixed, but has a few plan changes as a result. Please take another look. We can also move this to trunk if you prefer. http://gerrit.cloudera.org:8080/#/c/2367/7/fe/src/main/java/com/cloudera/impala/planner/SingleNodePlanner.java File fe/src/main/java/com/cloudera/impala/planner/SingleNodePlanner.java: Line 765: requiredTblRefIds.addAll(ref.getAllTupleIds()); This is the interesting change to fix this failing query: select c_custkey, c_mktsegment, o_orderkey, o_totalprice, o_orderdate from tpch_nested_parquet.customer c, c.c_orders o where c_custkey < 10 and o_orderdate like "1992%" and cast(o_orderdate as timestamp) + interval 13 days not in (select cast(l_shipdate as timestamp) from o.o_lineitems) -- To view, visit http://gerrit.cloudera.org:8080/2367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I298b8695c9f26644a395ca9f0e86040e3f5f3846 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-HasComments: Yes
