Alex Behm has posted comments on this change. Change subject: Fix test_exchange_delays in S3 build ......................................................................
Patch Set 1: Code-Review+1 I'm not super comfortable with the solution because we could silently lose coverage of the "CATCH" case (the test could always appear green and never hit the error case). At the same time, I don't have a better idea to fix this (talked to Tim about ideas). All timing based tests seem to be prone to either flakiness or silently losing coverage. Does anybody else have alternative ideas/comments? -- To view, visit http://gerrit.cloudera.org:8080/2421 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefd8631a2139b4dbc4502cf851fc2d16279d731f Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
