Henry Robinson has posted comments on this change. Change subject: CDH-36755 - Reuse session for executing queries (Hive on Spark) ......................................................................
Patch Set 1: (7 comments) Just passing through - I'll leave Ishaan or Taras to comment on whether this is a good idea. http://gerrit.cloudera.org:8080/#/c/2374/1/tests/performance/query_exec_functions.py File tests/performance/query_exec_functions.py: Line 39: threadLocal please use lower_underscore naming for variables. Line 42: cursor_set = [] not a set, it's a list Line 45: """Cleanup function : to close the global cursor : at exit time : """ This comment can be wrapped to fewer lines (although it is nearly a haiku in its current form!) Line 50: indent by two spaces, not four Line 53: import atexit keep imports together at the top of the file please Line 79: two spaces for indentation, here and everywhere else Line 87: cursor_set.append(threadLocal.cursor) if it's none, why not skip putting it in the list? -- To view, visit http://gerrit.cloudera.org:8080/2374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c798dc311d63eb0a875450fd26d06db4e84a03 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Kapil Rastogi <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Kapil Rastogi <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
