Michael Ho has posted comments on this change. Change subject: PREVIEW: IMPALA-3104: Catch exception on failure to create thread ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2453/2/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: Line 981: runtime_state_->query_resource_mgr()->IsVcoreOverSubscribed()) { Not your change but is this missing a ReleaseThreadToken(false) here ? Line 994: if (!thread_allocate_status.ok()) break; Do we need to call ReleaseThreadToken(false) here ? -- To view, visit http://gerrit.cloudera.org:8080/2453 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93629bbec08a0ea362794cd739503476e0caa1c5 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
