Tim Armstrong has posted comments on this change.

Change subject: Consolidate test and cluster logs under a single directory.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2456/2/bin/impala-config.sh
File bin/impala-config.sh:

Line 151: rm -rf ${IMPALA_HOME}/Testing
I've noticed that the backend test log redirection behaves more sanely if you 
pass impala::TestInfo::BE_TEST to InitCommonRuntime()

I fixed this in one or two places but it's not done everywhere.

Doesn't need to be this patch but it might be worth looking into.


-- 
To view, visit http://gerrit.cloudera.org:8080/2456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief1f58f3320ec39d31b3c6bc6ef87f58ff7dfdfa
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to