Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3142: avoid spinlock in MemTracker::GcMemory() ......................................................................
IMPALA-3142: avoid spinlock in MemTracker::GcMemory() When the process memory limit is exceeded we see excessive contention for the gc_lock_ in the process memory tracker. A SpinLock is not a good fit for this lock because we expect high contention (when the process memory limit is exceeded, it is exceeded globally and many threads will try to call into the function at the same time). boost::mutex will fall back to a kernel-level mutex and block the process instead of spinning. Change-Id: Ia9e91ea67ea924ba9b81e7376487838b365ca8ce Reviewed-on: http://gerrit.cloudera.org:8080/2459 Reviewed-by: Michael Ho <[email protected]> Reviewed-by: Alex Behm <[email protected]> Reviewed-by: Dan Hecht <[email protected]> Reviewed-by: Silvius Rus <[email protected]> Tested-by: Internal Jenkins --- M be/src/runtime/mem-tracker.cc M be/src/runtime/mem-tracker.h 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Ho: Looks good to me, but someone else must approve Internal Jenkins: Verified Silvius Rus: Looks good to me, approved Alex Behm: Looks good to me, but someone else must approve Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/2459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9e91ea67ea924ba9b81e7376487838b365ca8ce Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
