I forgot that part: -Werror is only set when building with the toolchain. If it proves to be a problem we can always add an option to explicitly enable it for precommit builds (or disable it for local builds).
On Mon, Mar 7, 2016 at 11:23 AM, Todd Lipcon <[email protected]> wrote: > Do you expect people to only build using the toolchain compiler from now > on? > > The issue I've had in the past with -Werror is that some people tend to > upgrade their compiler a bit earlier than others, and when you get a new > compiler, oftentimes it comes with new warnings. Then it's a real big pain > when you can no longer compile past releases with your new compiler. > > That said, I think it's a nice idea for the precommit builds since they use > a known-good compiler. > > -Todd > > On Mon, Mar 7, 2016 at 10:43 AM, Tim Armstrong <[email protected]> > wrote: > > > I committed a patch that makes any warnings compile errors (and fixes the > > irritating DISABLE_COPY_AND_ASSIGN warning that had crept into the > build). > > Currently this only applies to the debug build, so GVMs will fail if a > > patch introduces compile warnings. Release and ASAN will come later, but > > have been left out for now. > > > > Let me know if you run into any issues with the change: it can be > > irritating to have to fix compile warnings when you are iterating on > code, > > but I think it's worth it to have clean compiles. > > > > - Tim > > > > > > -- > Todd Lipcon > Software Engineer, Cloudera >
